8000 Incorrect use of pseudorandom numbers · Issue #114 · UBC-DSCI/introduction-to-datascience-python · GitHub
[go: up one dir, main page]

Skip to content
Incorrect use of pseudorandom numbers #114
Closed
@trevorcampbell

Description

@trevorcampbell

I've noticed that a lot of the code in Ch 6 is constantly setting random_state = 1. I may be wrong, but I'm fairly sure this is equivalent to fixing the random state of the PRNG at each function call where that argument is passed.

That's bad usage of prngs. You generally do not want to seed a PRNG many times -- just once -- because they only function as intended if they're run as a single long chain.

So: we should look through the book carefully once we have done the first round of polish to check for this bug.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0