8000 proper searching of earlier version · Tmusvit/winpython@af07d57 · GitHub
[go: up one dir, main page]

Skip to content

Commit af07d57

Browse files
committed
proper searching of earlier version
1 parent 4771b90 commit af07d57

File tree

1 file changed

+10
-4
lines changed

1 file changed

+10
-4
lines changed

diff.py

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -176,15 +176,21 @@ def find_closer_version(version1, basedir=None, flavor="", architecture=64):
176176
name,
177177
)
178178
versions = [func(name).groups()[0] for name in os.listdir(builddir) if func(name)]
179+
# versions:['3.10.0.1', '3.10.10.0', '3.10.2.0'.... '3.10.8.1', '3.10.9.0']
179180
try:
180181
index = versions.index(version1)
181182
except ValueError:
182183
raise ValueError(f"Unknown version {version1}")
183-
if index == 0:
184-
print(f"No version prior to {version1}")
185-
index += 1 # we don't want to fail on this
186-
return versions[index - 1]
187184

185+
from packaging import version
186+
version_below = '0.0.0.0'
187+
for v in versions:
188+
if version.parse(v) > version.parse(version_below) and version.parse(v)<version.parse(version1):
189+
version_below = v
190+
if version_below =='0.0.0.0':
191+
return version1
192+
else:
193+
return version_below
188194

189195
def compare_package_indexes(
190196
version2,

0 commit comments

Comments
 (0)
0