refactor: Always hide self and cls parameters

pawamoy · pawamoy · commit 7f579d162e18 · 2022-03-05T18:55:28.000+01:00
Issue mkdocstrings#7: mkdocstrings#7
diff --git a/src/mkdocstrings_handlers/python/templates/material/_base/class.html b/src/mkdocstrings_handlers/python/templates/material/_base/class.html
@@ -28,9 +28,7 @@
           {%- with function = class.members["__init__"] -%}
             {%- filter highlight(language="python", inline=True) -%}
               {% if show_full_path %}{{ class.path }}{% else %}{{ class.name }}{% endif %}
-              {% with no_self = True %}
-                {%- include "signature.html" with context -%}
-              {% endwith %}
+              {%- include "signature.html" with context -%}
             {%- endfilter -%}
           {%- endwith -%}
         {% else %}
@@ -45,7 +43,7 @@
 
       {% if config.separate_signature and config.merge_init_into_class %}
         {% if "__init__" in class.members %}
-          {% with function = class.members["__init__"], no_self = True %}
+          {% with function = class.members["__init__"] %}
             {% filter highlight(language="python", inline=False) %}
               {% filter format_signature(config.line_length) %}        
                 {% if show_full_path %}{{ class.path }}{% else %}{{ class.name }}{% endif %}
diff --git a/src/mkdocstrings_handlers/python/templates/material/_base/signature.html b/src/mkdocstrings_handlers/python/templates/material/_base/signature.html
@@ -10,7 +10,7 @@
 
     (
       {%- for parameter in function.parameters -%}
-        {%- if parameter.name != "self" or not no_self -%}
+        {%- if parameter.name not in ("self", "cls") or loop.index0 > 0 or not (function.parent and function.parent.is_class) -%}
 
           {%- if parameter.kind.value == "positional-only" -%}
             {%- if ns.render_pos_only_separator -%}

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@`
`10`	`10`
`11`	`11`	`(`
`12`	`12`	`{%- for parameter in function.parameters -%}`
`13`		`- {%- if parameter.name != "self" or not no_self -%}`
	`13`	`+ {%- if parameter.name not in ("self", "cls") or loop.index0 > 0 or not (function.parent and function.parent.is_class) -%}`
`14`	`14`
`15`	`15`	`{%- if parameter.kind.value == "positional-only" -%}`
`16`	`16`	`{%- if ns.render_pos_only_separator -%}`