8000 12_findTheOldest: Clarify test descriptions by RyanMcEntire · Pull Request #340 · TheOdinProject/javascript-exercises · GitHub
[go: up one dir, main page]
Skip to content

12_findTheOldest: Clarify test descriptions #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 27, 2023
Merged

12_findTheOldest: Clarify test descriptions #340

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions 12_findTheOldest/findTheOldest.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
const findTheOldest = require('./findTheOldest')

describe('findTheOldest', () => {
test('finds the oldest person!', () => {
test('finds the person with the greatest age!', () => {
const people = [
{
name: "Carly",
Expand All @@ -21,7 +21,7 @@ describe('findTheOldest', () => {
]
expect(findTheOldest(people).name).toBe('Ray');
});
test.skip('finds the oldest person if someone is still living', () => {
test.skip('finds the person with the greatest age if someone is still living', () => {
const people = [
{
name: "Carly",
Expand All @@ -40,7 +40,7 @@ describe('findTheOldest', () => {
]
expect(findTheOldest(people).name).toBe('Ray');
});
test.skip('finds the oldest person if the OLDEST is still living', () => {
test.skip('finds the person with the greatest age if the OLDEST is still living', () => {
const people = [
{
name: "Carly",
Expand Down
0