8000 Foundations: Inconsistent file naming · Issue #29328 · TheOdinProject/curriculum · GitHub
[go: up one dir, main page]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foundations: Inconsistent file naming #29328

Open
2 of 3 tasks
JackBogart opened this issue Jan 16, 2025 · 2 comments
Open
2 of 3 tasks

Foundations: Inconsistent file naming #29328

JackBogart opened this issue Jan 16, 2025 · 2 comments

Comments

@JackBogart
Copy link
Contributor
JackBogart commented Jan 16, 2025

Checks

Describe your suggestion

Small nit, noticed that directories/files in html/css, the file naming structure is different from the rest of the curriculum. Hyphens are being used as word separators here whereas underscores are used everywhere else. Not a huuuuge deal, but it's a little strange this is the only area it occurs.

IMO it's probably easier to make the file/directory names in this section use underscores rather than changing it everywhere else. I could do it but since it's so small, buuut I figured this would be a nice issue to create for anyone looking to contribute for the first time :)

Path

Foundations

Lesson Url

File/directories under foundations

(Optional) Discord Name

No response

(Optional) Additional Comments

No response

@JoshDevHub
Copy link
Contributor

Hello @JackBogart and thank you for making this issue.

This would be a larger change and more trouble than you think, and on that basis alone, I'm disinclined to pursue such a minor formatting thing.

The problem is: the actual site uses the file paths within the curriculum repo to import the lesson content. You can find the fixture used for defining the Foundations imports here. Any lesson that has its filename changed here will also need its github_path updated in the fixtures on the main site.

That said, I'll take this to the team and see what thoughts they have about it.

@MaoShizhong
Copy link
Contributor
MaoShizhong commented Jan 16, 2025

Also gotta check if that's the only directory with kebab case lesson files. If these were changed, and assuming there were no more kebab cases uncaught, the github workflows for linting would need path filtering amended, as will #28759

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
0