You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Small nit, noticed that directories/files in html/css, the file naming structure is different from the rest of the curriculum. Hyphens are being used as word separators here whereas underscores are used everywhere else. Not a huuuuge deal, but it's a little strange this is the only area it occurs.
IMO it's probably easier to make the file/directory names in this section use underscores rather than changing it everywhere else. I could do it but since it's so small, buuut I figured this would be a nice issue to create for anyone looking to contribute for the first time :)
Path
Foundations
Lesson Url
File/directories under foundations
(Optional) Discord Name
No response
(Optional) Additional Comments
No response
The text was updated successfully, but these errors were encountered:
Hello @JackBogart and thank you for making this issue.
This would be a larger change and more trouble than you think, and on that basis alone, I'm disinclined to pursue such a minor formatting thing.
The problem is: the actual site uses the file paths within the curriculum repo to import the lesson content. You can find the fixture used for defining the Foundations imports here. Any lesson that has its filename changed here will also need its github_path updated in the fixtures on the main site.
That said, I'll take this to the team and see what thoughts they have about it.
Also gotta check if that's the only directory with kebab case lesson files. If these were changed, and assuming there were no more kebab cases uncaught, the github workflows for linting would need path filtering amended, as will #28759
Checks
Describe your suggestion
Small nit, noticed that directories/files in html/css, the file naming structure is different from the rest of the curriculum. Hyphens are being used as word separators here whereas underscores are used everywhere else. Not a huuuuge deal, but it's a little strange this is the only area it occurs.
IMO it's probably easier to make the file/directory names in this section use underscores rather than changing it everywhere else. I could do it but since it's so small, buuut I figured this would be a nice issue to create for anyone looking to contribute for the first time :)
Path
Foundations
Lesson Url
File/directories under foundations
(Optional) Discord Name
No response
(Optional) Additional Comments
No response
The text was updated successfully, but these errors were encountered: