8000 Add annotations to the filename script so that a PR raised would notify the contributors about the files that don't follow the guideline · Issue #19 · TheAlgorithms/scripts · GitHub
[go: up one dir, main page]
Skip to content

Add annotations to the filename script so that a PR raised would notify the contributors about the files that don't follow the guideline #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Tracked by #17
tjgurwara99 opened this issue Mar 8, 2023 · 3 comments
Open
Tracked by #17

Add annotations to the filename script so that a PR raised would notify the contributors about the files that don't follow the guideline #19

8000 tjgurwara99 opened this issue Mar 8, 2023 · 3 comments
Assignees
@tjgurwara99
Labels
enhancement New feature or request

Comments

@tjgurwara99
Copy link
Member
tjgurwara99 commented Mar 8, 2023 •
edited
Loading

This is an issue to track the adding annotations to the filename script.

What do we mean by annotations? The following is an example of an annotation generated by a linter called golangci-lint. Generating them is quite straight forward, the docs explain this quite nicely.
Screenshot 2023-03-08 at 23 35 17
@tjgurwara99 tjgurwara99 mentioned this issue Mar 8, 2023
Open
2 tasks
@tjgurwara99 tjgurwara99 self-assigned this Mar 8, 2023
@tjgurwara99 tjgurwara99 mentioned this issue Mar 8, 2023
Open
@Panquesito7 Panquesito7 added the enhancement New feature or request label Jun 11, 2023
@Panquesito7
Copy link
Member

This is an awesome idea! 🚀
Let me know when you'll start working on it, and if you need any help.

@tjgurwara99
< 8ABE /svg> Copy link
Member Author

For the C++ one, I think what we should do is create a subprocess runner which parses the output of the linters and creates the annotations so that it can integrate well with GitHub. Have you got any experience working on parsers? It doesn't have to be fancy, you just need to take the output of another program and feed it into your program - I recommend Go or Python if you wanna start with it this parser part?

@Panquesito7
Copy link
Member

I'm not experienced with that, actually, never heard of it. 👀
I guess we can work together on that, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tjgurwara99 tjgurwara99

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tjgurwara99 @Panquesito7
0