Merge pull request TheOdinProject#428 from donRehan/main

thatblindgeye · web-flow · commit b09216355faa · 2024-02-13T17:24:09.000-05:00
12_findTheOldest fix ambiguity and remove redundant test description
diff --git a/12_findTheOldest/findTheOldest.spec.js b/12_findTheOldest/findTheOldest.spec.js
@@ -21,7 +21,7 @@ describe('findTheOldest', () => {
     ]
     expect(findTheOldest(people).name).toBe('Ray');
   });
-  test.skip('finds the person with the greatest age if someone is still living', () => {
+  test.skip('finds the oldest person if yearOfDeath field is undefined on a non-oldest person', () => {
     const people = [
       {
         name: "Carly",
@@ -40,7 +40,7 @@ describe('findTheOldest', () => {
     ]
     expect(findTheOldest(people).name).toBe('Ray');
   });
-  test.skip('finds the person with the greatest age if the OLDEST is still living', () => {
+  test.skip('finds the oldest person if yearOfDeath field is undefined for the oldest person', () => {
     const people = [
       {
         name: "Carly",

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ describe('findTheOldest', () => {`
`21`	`21`	`]`
`22`	`22`	`expect(findTheOldest(people).name).toBe('Ray');`
`23`	`23`	`});`
`24`		`- test.skip('finds the person with the greatest age if someone is still living', () => {`
	`24`	`+ test.skip('finds the oldest person if yearOfDeath field is undefined on a non-oldest person', () => {`
`25`	`25`	`const people = [`
`26`	`26`	`{`
`27`	`27`	`name: "Carly",`
`@@ -40,7 +40,7 @@ describe('findTheOldest', () => {`
`40`	`40`	`]`
`41`	`41`	`expect(findTheOldest(people).name).toBe('Ray');`
`42`	`42`	`});`
`43`		`- test.skip('finds the person with the greatest age if the OLDEST is still living', () => {`
	`43`	`+ test.skip('finds the oldest person if yearOfDeath field is undefined for the oldest person', () => {`
`44`	`44`	`const people = [`
`45`	`45`	`{`
`46`	`46`	`name: "Carly",`