@@ -143,24 +143,17 @@ def is_member(self, username):
143
143
return self ._boolean (self ._get (url ), 204 , 404 )
144
144
145
145
@requires_auth
146
- def members (self , filter = None , number = - 1 , etag = None ):
146
+ def members (self , number = - 1 , etag = None ):
147
147
r"""Iterate over the members of this team.
148
148
149
- :param str filter: (optional), filter members returned by this method.
150
- Can be one of: ``"2fa_disabled"``, ``"all",``. Default: ``"all"``.
151
- Filtering by ``"2fa_disabled"`` is only available for organization
152
- owners with private repositories.
153
149
:param int number: (optional), number of users to iterate over.
154
150
Default: -1 iterates over all values
155
151
:param str etag: (optional), ETag from a previous request to the same
156
152
endpoint
157
153
:returns: generator of :class:`User <github3.users.User>`\ s
158
154
"""
159
- params = {}
160
- if filter in set (["2fa_disabled" , "all" ]):
161
- params ['filter' ] = filter
162
155
url = self ._build_url ('members' , base_url = self ._api )
163
- return self ._iter (int (number ), url , User , params = params , etag = etag )
156
+ return self ._iter (int (number ), url , User , etag = etag )
164
157
165
158
@requires_auth
166
159
def repositories (self , number = - 1 , etag = None ):
@@ -451,17 +444,24 @@ def events(self, number=-1, etag=None):
451
444
url = self ._build_url ('events' , base_url = self ._api )
452
445
return self ._iter (int (number ), url , Event , etag = etag )
453
446
454
- def members (self , number = - 1 , etag = None ):
447
+ def members (self , filter = None , number = - 1 , etag = None ):
455
448
r"""Iterate over members of this organization.
456
449
450
+ :param str filter: (optional), filter members returned by this method.
451
+ Can be one of: ``"2fa_disabled"``, ``"all",``. Default: ``"all"``.
452
+ Filtering by ``"2fa_disabled"`` is only available for organization
453
+ owners with private repositories.
457
454
:param int number: (optional), number of members to return. Default:
458
455
-1 will return all available.
459
456
:param str etag: (optional), ETag from a previous request to the same
460
457
endpoint
461
458
:returns: generator of :class:`User <github3.users.User>`\ s
462
459
"""
460
+ params = {}
461
+ if filter in set (["2fa_disabled" , "all" ]):
462
+ params ['filter' ] = filter
463
463
url = self ._build_url ('members' , base_url = self ._api )
464
- return self ._iter (int (number ), url , User , etag = etag )
464
+ return self ._iter (int (number ), url , User , params = params , etag = etag )
465
465
466
466
def public_members (self , number = - 1 , etag = None ):
467
467
r"""Iterate over public members of this organization.
0 commit comments