chore: Fix several supported version things (#47)

chapterjason · web-flow · commit 8e8be145f024 · 2021-08-02T20:41:16.000+02:00
* chore: Several version related changes

* cut: Remove check for older symfony version

* fix: baseline
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -17,7 +17,7 @@ jobs:
           - 'lowest'
         symfony:
           - '4.4.*'
-          - '5.0.*'
+          - '5.3.*'
           - '6.0.*'
         exclude:
           - php: '7.2'
@@ -33,8 +33,6 @@ jobs:
             symfony: '4.4.*'
           - php: '7.4'
             symfony: '6.0.*'
-          - php: '8.0'
-            symfony: '3.4.*'
           - php: '8.0'
             symfony: '4.4.*'
       fail-fast: false
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -25,11 +25,6 @@ parameters:
 			count: 1
 			path: src/BaseBundleTestCase.php
 
-		-
-			message: "#^Comparison operation \"\\>\\=\" between 50306 and 30300 is always true\\.$#"
-			count: 1
-			path: src/config/parameters.php
-
 		-
 			message: "#^Comparison operation \"\\>\\=\" between 50306 and 50100 is always true\\.$#"
 			count: 1
diff --git a/src/config/parameters.php b/src/config/parameters.php
@@ -1,7 +1,7 @@
 <?php
 
-// If sf 3.3 and no annotations is installed, then disable it.
-if (\Symfony\Component\HttpKernel\Kernel::VERSION_ID >= 30300 && !class_exists('Doctrine\Common\Annotations\Annotation')) {
+// If annotations aren't installed, disable it.
+if (!class_exists('Doctrine\Common\Annotations\Annotation')) {
     $container->loadFromExtension('framework', [
         'annotations' => ['enabled' => false],
     ]);
diff --git a/tests/Fixtures/ConfigurationBundle/DependencyInjection/Configuration.php b/tests/Fixtures/ConfigurationBundle/DependencyInjection/Configuration.php
@@ -13,12 +13,7 @@ final class Configuration implements ConfigurationInterface
     public function getConfigTreeBuilder()
     {
         $tree = new TreeBuilder('configuration');
-
-        if (method_exists($tree, 'getRootNode')) {
-            $root = $tree->getRootNode();
-        } else {
-            $root = $tree->root('configuration');
-        }
+        $root = $tree->getRootNode();
 
         $root
             ->children()
