-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Closed
Labels
Potential BugPotential bugs or bugfixes, that needs to be reproduced.Potential bugs or bugfixes, that needs to be reproduced.RFCDiscussions about potential changes or new features.Discussions about potential changes or new features.
Description
The docs tell us that the FOSRestBundle
is needed in order to use the PromotionBundle
. http://docs.sylius.org/en/latest/bundles/SyliusPromotionBundle/installation.html#adding-required-bundles-to-the-kernel
We recently upgraded libxml to 2.9.2
and the restbundle it's BodyListener
throws an BadRequestHttpException
because it is registered on kernel.event
and we have XML nodes that are > 10MB (see symfony/symfony#16873 for more info). Because of the listener we can't handle this in the controller ourselves.
So, given we don't use the actual WhiteOctoberPagerfantaBundle
, FOSRestBundle
and JMSSerializerBundle
ourselves, would it hurt if we remove these bundles from the kernel? In what specific cases are these bundles really needed?
Metadata
Metadata
Assignees
Labels
Potential BugPotential bugs or bugfixes, that needs to be reproduced.Potential bugs or bugfixes, that needs to be reproduced.RFCDiscussions about potential changes or new features.Discussions about potential changes or new features.