Convert Reference.IsTag() into a property

nulltoken · nulltoken · commit b2fbbfbf499d · 2015-06-18T17:45:11.000+02:00
diff --git a/LibGit2Sharp.Tests/ReferenceFixture.cs b/LibGit2Sharp.Tests/ReferenceFixture.cs
@@ -831,7 +831,7 @@ public void CanIdentifyReferenceKind()
             {
                 Assert.True(repo.Refs["refs/heads/master"].IsLocalBranch);
                 Assert.True(repo.Refs["refs/remotes/origin/master"].IsRemoteTrackingBranch);
-                Assert.True(repo.Refs["refs/tags/lw"].IsTag());
+                Assert.True(repo.Refs["refs/tags/lw"].IsTag);
             }
 
             path = SandboxBareTestRepo();
@@ -871,7 +871,7 @@ public void CanQueryReachabilityAmongASubsetOfreferences()
             using (var repo = new Repository(path))
             {
                 var result = repo.Refs.ReachableFrom(
-                    repo.Refs.Where(r => r.IsTag()),
+                    repo.Refs.Where(r => r.IsTag),
                     new[] { repo.Lookup<Commit>("f8d44d7"), repo.Lookup<Commit>("6dcf9bf") });
 
                 var expected = new[]
diff --git a/LibGit2Sharp/Core/HistoryRewriter.cs b/LibGit2Sharp/Core/HistoryRewriter.cs
@@ -141,7 +141,7 @@ private Reference RewriteReference<TRef, TTarget>(
             var oldRefTarget = selectTarget(oldRef);
 
             string newRefName = oldRef.CanonicalName;
-            if (oldRef.IsTag() && options.TagNameRewriter != null)
+            if (oldRef.IsTag && options.TagNameRewriter != null)
             {
                 newRefName = Reference.TagPrefix +
                              options.TagNameRewriter(oldRef.CanonicalName.Substring(Reference.TagPrefix.Length),
diff --git a/LibGit2Sharp/Reference.cs b/LibGit2Sharp/Reference.cs
@@ -105,9 +105,9 @@ public virtual bool IsRemoteTrackingBranch
         /// Determine if the current <see cref="Reference"/> is a tag.
         /// </summary>
         /// <returns>true if the current <see cref="Reference"/> is a tag, false otherwise.</returns>
-        public virtual bool IsTag()
+        public virtual bool IsTag
         {
-            return CanonicalName.LooksLikeTag();
+            get { return CanonicalName.LooksLikeTag(); }
         }
 
         /// <summary>

Original file line number	Diff line number	Diff line change
`@@ -831,7 +831,7 @@ public void CanIdentifyReferenceKind()`
`831`	`831`	`{`
`832`	`832`	`Assert.True(repo.Refs["refs/heads/master"].IsLocalBranch);`
`833`	`833`	`Assert.True(repo.Refs["refs/remotes/origin/master"].IsRemoteTrackingBranch);`
`834`		`- Assert.True(repo.Refs["refs/tags/lw"].IsTag());`
	`834`	`+ Assert.True(repo.Refs["refs/tags/lw"].IsTag);`
`835`	`835`	`}`
`836`	`836`
`837`	`837`	`path = SandboxBareTestRepo();`
`@@ -871,7 +871,7 @@ public void CanQueryReachabilityAmongASubsetOfreferences()`
`871`	`871`	`using (var repo = new Repository(path))`
`872`	`872`	`{`
`873`	`873`	`var result = repo.Refs.ReachableFrom(`
`874`		`- repo.Refs.Where(r => r.IsTag()),`
	`874`	`+ repo.Refs.Where(r => r.IsTag),`
`875`	`875`	`new[] { repo.Lookup<Commit>("f8d44d7"), repo.Lookup<Commit>("6dcf9bf") });`
`876`	`876`
`877`	`877`	`var expected = new[]`
Original file line number	Diff line number	Diff line change
`@@ -141,7 +141,7 @@ private Reference RewriteReference<TRef, TTarget>(`
`141`	`141`	`var oldRefTarget = selectTarget(oldRef);`
`142`	`142`
`143`	`143`	`string newRefName = oldRef.CanonicalName;`
`144`		`- if (oldRef.IsTag() && options.TagNameRewriter != null)`
	`144`	`+ if (oldRef.IsTag && options.TagNameRewriter != null)`
`145`	`145`	`{`
`146`	`146`	`newRefName = Reference.TagPrefix +`
`147`	`147`	`options.TagNameRewriter(oldRef.CanonicalName.Substring(Reference.TagPrefix.Length),`
Original file line number	Diff line number	Diff line change
`@@ -105,9 +105,9 @@ public virtual bool IsRemoteTrackingBranch`
`105`	`105`	`/// Determine if the current <see cref="Reference"/> is a tag.`
`106`	`106`	`/// </summary>`
`107`	`107`	`/// <returns>true if the current <see cref="Reference"/> is a tag, false otherwise.</returns>`
`108`		`- public virtual bool IsTag()`
	`108`	`+ public virtual bool IsTag`
`109`	`109`	`{`
`110`		`- return CanonicalName.LooksLikeTag();`
	`110`	`+ get { return CanonicalName.LooksLikeTag(); }`
`111`	`111`	`}`
`112`	`112`
`113`	`113`	`/// <summary>`