adds some IDF error return conditions

SuGlider · web-flow · commit d37a199ebe23 · 2022-12-06T16:57:06.000-03:00
diff --git a/cores/esp32/esp32-hal-uart.c b/cores/esp32/esp32-hal-uart.c
@@ -354,7 +354,8 @@ size_t uartReadBytes(uart_t* uart, uint8_t *buffer, size_t size, uint32_t timeou
     return bytes_read;
 }
 
-
+// DEPRICATED but the original code will be kepts here as future reference when a final solution
+// to the UART driver is defined in the use case of reading byte by byte from UART.
 uint8_t uartRead(uart_t* uart)
 {
     if(uart == NULL) {
@@ -370,14 +371,15 @@ uint8_t uartRead(uart_t* uart)
     } else {
 
         int len = uart_read_bytes(uart->num, &c, 1, 20 / portTICK_RATE_MS);
-        if (len == 0) {
+        if (len <= 0) { // includes negative return from IDF in case of error
             c  = 0;
         }
     }
     UART_MUTEX_UNLOCK();
     return c;
 }
 
+
 uint8_t uartPeek(uart_t* uart)
 {
     if(uart == NULL) {
@@ -391,7 +393,7 @@ uint8_t uartPeek(uart_t* uart)
       c = uart->peek_byte;
     } else {
         int len = uart_read_bytes(uart->num, &c, 1, 20 / portTICK_RATE_MS);
-        if (len == 0) {
+        if (len <= 0) { // includes negative return from IDF in case of error
             c  = 0;
         } else {
             uart->has_peek = true;

Original file line number	Diff line number	Diff line change
`@@ -354,7 +354,8 @@ size_t uartReadBytes(uart_t* uart, uint8_t *buffer, size_t size, uint32_t timeou`
`354`	`354`	`return bytes_read;`
`355`	`355`	`}`
`356`	`356`
`357`		`-`
	`357`	`+// DEPRICATED but the original code will be kepts here as future reference when a final solution`
	`358`	`+// to the UART driver is defined in the use case of reading byte by byte from UART.`
`358`	`359`	`uint8_t uartRead(uart_t* uart)`
`359`	`360`	`{`
`360`	`361`	`if(uart == NULL) {`
`@@ -370,14 +371,15 @@ uint8_t uartRead(uart_t* uart)`
`370`	`371`	`} else {`
`371`	`372`
`372`	`373`	`int len = uart_read_bytes(uart->num, &c, 1, 20 / portTICK_RATE_MS);`
`373`		`- if (len == 0) {`
	`374`	`+ if (len <= 0) { // includes negative return from IDF in case of error`
`374`	`375`	`c = 0;`
`375`	`376`	`}`
`376`	`377`	`}`
`377`	`378`	`UART_MUTEX_UNLOCK();`
`378`	`379`	`return c;`
`379`	`380`	`}`
`380`	`381`
	`382`	`+`
`381`	`383`	`uint8_t uartPeek(uart_t* uart)`
`382`	`384`	`{`
`383`	`385`	`if(uart == NULL) {`
`@@ -391,7 +393,7 @@ uint8_t uartPeek(uart_t* uart)`
`391`	`393`	`c = uart->peek_byte;`
`392`	`394`	`} else {`
`393`	`395`	`int len = uart_read_bytes(uart->num, &c, 1, 20 / portTICK_RATE_MS);`
`394`		`- if (len == 0) {`
	`396`	`+ if (len <= 0) { // includes negative return from IDF in case of error`
`395`	`397`	`c = 0;`
`396`	`398`	`} else {`
`397`	`399`	`uart->has_peek = true;`