8000 Make tests pass again · StevenLudwig/twilio-python@ac0669e · GitHub
[go: up one dir, main page]
Skip to content

Commit ac0669e

Browse files
skimbrelskimbrel
committed
Make tests pass again
1 parent c06f81f commit ac0669e

File tree

2 files changed

+18
-17
lines changed

2 files changed

+18
-17
lines changed

‎tests/task_router/test_statistics.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,11 @@ def test_fetch_task_queue_statistics(request):
4040
resp.status_code = 200
4141
request.return_value = resp
4242

43-
tqs = TaskQueues(BASE_URI, AUTH)
43+
tqs = TaskQueues(BASE_URI, AUTH, 30)
4444
tq = TaskQueue(tqs, 'TQ123')
4545
tq.load_subresources()
4646
tq.statistics.get()
47-
request.assert_called_with('GET', '{}/TaskQueues/TQ123/Statistics'.format(BASE_URI), params={}, auth=AUTH)
47+
request.assert_called_with('GET', '{}/TaskQueues/TQ123/Statistics'.format(BASE_URI), params={}, auth=AUTH, timeout=30)
4848

4949

5050
@patch("twilio.rest.resources.base.make_twilio_request")
@@ -53,7 +53,7 @@ def test_fetch_task_queues_statistics(request):
5353
resp.status_code = 200
5454
request.return_value = resp
5555

56-
tqs = TaskQueues(BASE_URI, AUTH)
56+
tqs = TaskQueues(BASE_URI, AUTH, 30)
5757
tqs.statistics.get()
5858
request.assert_called_with('GET', '{}/TaskQueues/Statistics'.format(BASE_URI), params={}, auth=AUTH)
5959

‎tests/task_router/test_task_queues.py

Lines changed: 15 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
AUTH = ("AC123", "token")
1010
BASE_URI = "https://taskrouter.twilio.com/v1/Accounts/AC123/Workspaces/WSaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
1111
TASK_QUEUE_SID = "WQaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
12+
TIMEOUT = 30
1213

1314

1415
class TaskQueueTest(unittest.TestCase):
@@ -18,15 +19,15 @@ def test_create(self, request):
1819
resp.status_code = 201
1920
request.return_value = resp
2021

21-
task_queues = TaskQueues(BASE_URI, AUTH)
22+
task_queues = TaskQueues(BASE_URI, AUTH, TIMEOUT)
2223
task_queues.create("Test TaskQueue", "WAaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa", "WAaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa")
2324
exp_params = {
2425
'FriendlyName': "Test TaskQueue",
2526
'AssignmentActivitySid': "WAaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa",
2627
'ReservationActivitySid': 'WAaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'
2728
}
2829

29-
request.assert_called_with("POST", "{}/TaskQueues".format(BASE_URI), data=exp_params, auth=AUTH)
30+
request.assert_called_with("POST", "{}/TaskQueues".format(BASE_URI), data=exp_params, auth=AUTH, timeout=TIMEOUT)
3031

3132
@patch('twilio.rest.resources.base.make_twilio_request')
3233
def test_delete_instance(self, request):
@@ -36,10 +37,10 @@ def test_delete_instance(self, request):
3637
request.return_value = resp
3738

3839
uri = "{}/TaskQueues/{}".format(BASE_URI, TASK_QUEUE_SID)
39-
list_resource = TaskQueues(BASE_URI, AUTH)
40+
list_resource = TaskQueues(BASE_URI, AUTH, TIMEOUT)
4041
task_queue = TaskQueue(list_resource, TASK_QUEUE_SID)
4142
task_queue.delete()
42-
request.assert_called_with("DELETE", uri, auth=AUTH)
43+
request.assert_called_with("DELETE", uri, auth=AUTH, timeout=TIMEOUT)
4344

4445
@patch('twilio.rest.resources.base.make_twilio_request')
4546
def test_delete_list(self, request):
@@ -49,9 +50,9 @@ def test_delete_list(self, request):
4950
request.return_value = resp
5051

5152
uri = "{}/TaskQueues/{}".format(BASE_URI, TASK_QUEUE_SID)
52-
list_resource = TaskQueues(BASE_URI, AUTH)
53+
list_resource = TaskQueues(BASE_URI, AUTH, TIMEOUT)
5354
list_resource.delete(TASK_QUEUE_SID)
54-
request.assert_called_with("DELETE", uri, auth=AUTH)
55+
request.assert_called_with("DELETE", uri, auth=AUTH, timeout=TIMEOUT)
5556

5657
@patch('twilio.rest.resources.base.make_twilio_request')
5758
def test_get(self, request):
@@ -60,9 +61,9 @@ def test_get(self, request):
6061
request.return_value = resp
6162

6263
uri = "{}/TaskQueues/{}".format(BASE_URI, TASK_QUEUE_SID)
63-
list_resource = TaskQueues(BASE_URI, AUTH)
64+
list_resource = TaskQueues(BASE_URI, AUTH, TIMEOUT)
6465
list_resource.get(TASK_QUEUE_SID)
65-
request.assert_called_with("GET", uri, auth=AUTH)
66+
request.assert_called_with("GET", uri, auth=AUTH, timeout=TIMEOUT)
6667

6768
@patch('twilio.rest.resources.base.make_twilio_request')
6869
def test_list(self, request):
@@ -71,9 +72,9 @@ def test_list(self, request):
7172
request.return_value = resp
7273

7374
uri = "{}/TaskQueues".format(BASE_URI)
74-
list_resource = TaskQueues(BASE_URI, AUTH)
75+
list_resource = TaskQueues(BASE_URI, AUTH, TIMEOUT)
7576
list_resource.list()
76-
request.assert_called_with("GET", uri, params={}, auth=AUTH)
77+
request.assert_called_with("GET", uri, params={}, auth=AUTH, timeout=TIMEOUT)
7778

7879
@patch('twilio.rest.resources.base.make_twilio_request')
7980
def test_update_instance(self, request):
@@ -82,7 +83,7 @@ def test_update_instance(self, request):
8283
request.return_value = resp
8384

8485
uri = "{}/TaskQueues/{}".format(BASE_URI, TASK_QUEUE_SID)
85-
list_resource = TaskQueues(BASE_URI, AUTH)
86+
list_resource = TaskQueues(BASE_URI, AUTH, TIMEOUT)
8687
task_queue = TaskQueue(list_resource, TASK_QUEUE_SID)
8788
task_queue.update(friendly_name='Test TaskQueue', assignment_activity_sid='WAaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa',
8889
reservation_activity_sid='WAaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa')
@@ -92,7 +93,7 @@ def test_update_instance(self, request):
9293
'ReservationActivitySid': 'WAaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'
9394
}
9495

95-
request.assert_called_with("POST", uri, data=exp_params, auth=AUTH)
96+
request.assert_called_with("POST", uri, data=exp_params, auth=AUTH, timeout=TIMEOUT)
9697

9798
@patch('twilio.rest.resources.base.make_twilio_request')
9899
def test_update_list(self, request):
@@ -101,7 +102,7 @@ def test_update_list(self, request):
101102
request.return_value = resp
102103

103104
uri = "{}/TaskQueues/{}".format(BASE_URI, TASK_QUEUE_SID)
104-
list_resource = TaskQueues(BASE_URI, AUTH)
105+
list_resource = TaskQueues(BASE_URI, AUTH, TIMEOUT)
105106
list_resource.update(TASK_QUEUE_SID, friendly_name='Test TaskQueue',
106107
assignment_activity_sid='WAaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa',
107108
reservation_activity_sid='WAaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa')
@@ -111,4 +112,4 @@ def test_update_list(self, request):
111112
'ReservationActivitySid': 'WAaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'
112113
}
113114

114-
request.assert_called_with("POST", uri, data=exp_params, auth=AUTH)
115+
request.assert_called_with("POST", uri, data=exp_params, auth=AUTH, timeout=TIMEOUT)

0 commit comments

Comments
 (0)
0