add reject fn to async component factory

yyx990803 · yyx990803 · commit ba896479e278 · 2015-06-01T20:53:10.000-04:00
diff --git a/src/instance/misc.js b/src/instance/misc.js
@@ -57,6 +57,7 @@ exports._resolveComponent = function (id, cb) {
       // cached
       cb(factory.resolved)
     } else if (factory.requested) {
+      // pool callbacks
       factory.pendingCallbacks.push(cb)
     } else {
       factory.requested = true
@@ -71,6 +72,11 @@ exports._resolveComponent = function (id, cb) {
         for (var i = 0, l = cbs.length; i < l; i++) {
           cbs[i](res)
         }
+      }, function reject (reason) {
+        _.warn(
+          'Failed to resolve async component: ' + id + '. ' +
+          (reason ? '\nReason: ' + reason : '')
+        )
       })
     }
   } else {
diff --git a/test/unit/specs/async_component_spec.js b/test/unit/specs/async_component_spec.js
@@ -182,6 +182,19 @@ describe('Async components', function () {
         done()
       }
     })
+
+    it('warn reject', function () {
+      var vm = new Vue({
+        el: el,
+        template: '<test></test>',
+        components: {
+          test: function (resolve, reject) {
+            reject('nooooo')
+          }
+        }
+      })
+      expect(hasWarned(_, 'Reason: nooooo')).toBe(true)
+    })
   })
 
   describe('v-repeat', function () {
