8000 Removed print statemets, nit cleanups. · SnarkyPapi/server-client-python@af7acaa · GitHub
[go: up one dir, main page]

Skip to content

Commit af7acaa

Browse files
lbrendanlRussell Hay
authored and
Russell Hay
committed
Removed print statemets, nit cleanups.
1 parent 71e600a commit af7acaa

File tree

6 files changed

+7
-9
lines changed

6 files changed

+7
-9
lines changed

tableauserverclient/models/tagged_resource_item.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,4 @@ def _get_initial_tags(self):
1010
return self._initial_tags
1111

1212
def _set_initial_tags(self, initial_tags):
13-
self._initial_tags = initial_tags
13+
self._initial_tags = initial_tags

tableauserverclient/server/endpoint/datasources_endpoint.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,9 +105,7 @@ def update(self, datasource_item):
105105
# Update the datasource itself
106106
url = "{0}/{1}".format(self.baseurl, datasource_item.id)
107107
update_req = RequestFactory.Datasource.update_req(datasource_item)
108-
print(update_req)
109108
server_response = self.put_request(url, update_req)
110-
print(server_response)
111109
logger.info('Updated datasource item (ID: {0})'.format(datasource_item.id))
112110
updated_datasource = copy.copy(datasource_item)
113111
return updated_datasource._parse_common_tags(server_response.content)

tableauserverclient/server/endpoint/tagged_resources_endpoint.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,4 +30,4 @@ def _update_tags(self, baseurl, resource_item):
3030
if add_set:
3131
resource_item.tags = self._add_tags(baseurl, resource_item.id, add_set)
3232
resource_item._initial_tags = copy.copy(resource_item.tags)
33-
logger.info('Updated tags to {0}'.format(resource_item.tags))
33+
logger.info('Updated tags to {0}'.format(resource_item.tags))

tableauserverclient/server/endpoint/views_endpoint.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,9 @@
1010

1111

1212
class Views(TaggedResourcesEndpoint):
13+
# Used because populate_preview_image functionaliy requires workbook endpoint
1314
@property
14-
def siteurl(self):
15+
def siteurl(self):
1516
return "{0}/sites/{1}".format(self.parent_srv.baseurl, self.parent_srv.site_id)
1617

1718

@@ -21,8 +22,7 @@ def baseurl(self):
2122

2223
def get(self, req_options=None):
2324
logger.info('Querying all views on site')
24-
url = self.baseurl
25-
server_response = self.get_request(url, req_options)
25+
server_response = self.get_request(self.baseurl, req_options)
2626
pagination_item = PaginationItem.from_response(server_response.content)
2727
all_view_items = ViewItem.from_response(server_response.content)
2828
return all_view_items, pagination_item

test/assets/datasource_add_tags.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@
66
<tag label="c" />
77
<tag label="d" />
88
</tags>
9-
</tsResponse>
9+
</tsResponse>

test/assets/view_add_tags.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@
66
<tag label="c" />
77
<tag label="d" />
88
</tags>
9-
</tsResponse>
9+
</tsResponse>

0 commit comments

Comments
 (0)
0