8000 bug #12628 [API] Conflict with symfony/property-info due to problem w… · SirDomin/Sylius@3458958 · GitHub
[go: up one dir, main page]

Skip to content

Commit 3458958

Zales0123SirDomin
authored andcommitted
bug Sylius#12628 [API] Conflict with symfony/property-info due to problem with wrong namespaces of some translation entities (GSadee)
This PR was merged into the 1.9 branch. Discussion ---------- | Q | A | --------------- | ----- | Branch? | 1.9 | Bug fix? | yes | New feature? | no/ | BC breaks? | no | Deprecations? | no | Related tickets | probably introduced in symfony/symfony#40811 | License | MIT The problem occurs in Swagger UI docs and there is a problem with resolving proper namespaces during serializing translation entities, e.g.: ![image](https://user-images.githubusercontent.com/6140884/117978269-fb8ca500-b331-11eb-8dcc-08b1e346954a.png) Commits ------- dc01355 [API] Conflict with symfony/property-info due to problem with wrong namespaces of some translation entities
2 parents 960d349 + dc01355 commit 3458958

File tree

3 files changed

+11
-0
lines changed

3 files changed

+11
-0
lines changed

CONFLICTS.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,3 +53,12 @@ references related issues.
5353
`ParseError - vendor/symfony/polyfill-mbstring/bootstrap80.php:125:86 - Syntax error, unexpected '=' on line 125 (see https://psalm.dev/173) function mb_scrub(string $string, string $encoding = null): string { $encoding ??= mb_internal_encoding(); return mb_convert_encoding($string, $encoding, $encoding); }`
5454

5555
References: https://github.com/vimeo/psalm/issues/4961
56+
57+
- `symfony/property-info:4.4.22|5.2.7`:
58+
59+
These versions of Symfony PropertyInfo Component introduce a bug with resolving wrong namespace for some translation entities
60+
in Swagger UI docs for API.
61+
62+
The potential solution would be to explicitly define these translation entities as API resources with proper serialization.
63+
64+
Probably introduced in: https://github.com/symfony/symfony/pull/40811

composer.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -166,6 +166,7 @@
166166
"laminas/laminas-code": "^4.0.0",
167167
"symfony/doctrine-bridge": "4.4.16",
168168
"symfony/polyfill-mbstring": "^1.22.0",
169+
"symfony/property-info": "4.4.22 || 5.2.7",
169170
"symfony/serializer": "4.4.19 || 5.2.2"
170171
},
171172
"require-dev": {

src/Sylius/Bundle/ApiBundle/Resources/config/app/config.yaml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ parameters:
1313
sylius.security.new_api_user_account_route: "%sylius.security.new_api_shop_route%/account"
1414
sylius.security.new_api_user_account_regex: "^%sylius.security.new_api_user_account_route%"
1515

16+
1617
api_platform:
1718
patch_formats:
1819
json: ['application/merge-patch+json']

0 commit comments

Comments
 (0)
0