[BrowserKit] fix symfony#20306 add a way to unset server parameter

Amrouche Hamza · Amrouche Hamza · commit e61b6b897802 · 2016-12-11T10:57:32.000+01:00
diff --git a/src/Symfony/Component/BrowserKit/Client.php b/src/Symfony/Component/BrowserKit/Client.php
@@ -138,6 +138,16 @@ public function setServerParameter($key, $value)
         $this->server[$key] = $value;
     }
 
+    /**
+     * Unset single server parameter.
+     *
+     * @param string $key A key of the parameter
+     */
+    public function unSetServerParameter($key)
+    {
+        unset($this->server[$key]);
+    }
+
     /**
      * Gets single server parameter for specified key.
      *
diff --git a/src/Symfony/Component/BrowserKit/Tests/ClientTest.php b/src/Symfony/Component/BrowserKit/Tests/ClientTest.php
@@ -620,6 +620,31 @@ public function testSetServerParameter()
         $this->assertEquals('testua', $client->getServerParameter('HTTP_USER_AGENT'));
     }
 
+    public function testUnSetServerParameter()
+    {
+        $client = new TestClient();
+
+        $this->assertEquals('', $client->getServerParameter('HTTP_HOST'));
+        $this->assertEquals('Symfony BrowserKit', $client->getServerParameter('HTTP_USER_AGENT'));
+
+        $client->setServerParameter('HTTP_HOST', 'testhost');
+        $client->unSetServerParameter('HTTP_HOST');
+
+        $this->assertEquals('', $client->getServerParameter('HTTP_HOST'));
+
+        $client->setServerParameter('HTTP_USER_AGENT', 'testua');
+        $client->unSetServerParameter('HTTP_USER_AGENT');
+
+        $this->assertEquals('', $client->getServerParameter('HTTP_USER_AGENT'));
+
+        $client->setServerParameter('HTTP_X-Requested-With', 'XMLHttpRequest');
+        $client->unSetServerParameter('HTTP_X-Requested-With');
+
+        $client->unSetServerParameter('HTTP_X-fefef-With');
+
+        $this->assertEquals('', $client->getServerParameter('HTTP_X-Requested-With'));
+    }
+
     public function testSetServerParameterInRequest()
     {
         $client = new TestClient();
