@@ -80,15 +80,13 @@ public function getDecoratedFactory()
80
80
* @param null|callable|string|PropertyPath $value The callable or path for
81
81
* generating the choice values
82
82
*
83
- * @deprecated We should not treat callable strings as callable
84
- *
85
83
* @return ChoiceListInterface The choice list
86
84
*/
87
85
public function createListFromChoices ($ choices , $ value = null )
88
86
{
89
87
if (is_string ($ value ) && !is_callable ($ value )) {
90
88
$ value = new PropertyPath ($ value );
91
- } elseif (is_string ($ value ) && is_callable ($ value )) {
89
+ } elseif (is_string ($ value ) && is_callable ($ value )) {
92
90
@trigger_error ('createListFromChoices() treats callable strings as callable and is deprecated since version 3.0. ' , E_USER_DEPRECATED );
93
91
}
94
92
@@ -115,15 +113,13 @@ public function createListFromChoices($choices, $value = null)
115
113
* @param null|callable|string|PropertyPath $value The callable or path for
116
114
* generating the choice values
117
115
*
118
- * @deprecated We should not treat callable strings as callable
119
- *
120
116
* @return ChoiceListInterface The choice list
121
117
*/
122
118
public function createListFromLoader (ChoiceLoaderInterface $ loader , $ value = null )
123
119
{
124
120
if (is_string ($ value ) && !is_callable ($ value )) {
125
121
$ value = new PropertyPath ($ value );
126
- } elseif (is_string ($ value ) && is_callable ($ value )) {
122
+ } elseif (is_string ($ value ) && is_callable ($ value )) {
127
123
@trigger_error ('createListFromLoader() treats callable strings as callable and is deprecated since version 3.0. ' , E_USER_DEPRECATED );
128
124
}
129
125
@@ -153,8 +149,6 @@ public function createListFromLoader(ChoiceLoaderInterface $loader, $value = nul
153
149
* @param null|callable|string|PropertyPath $groupBy The callable or path generating the group names
154
150
* @param null|array|callable|string|PropertyPath $attr The callable or path generating the HTML attributes
155
151
*
156
- * @deprecated We should not treat callable strings as callable
157
- *
158
152
* @return ChoiceListView The choice list view
159
153
*/
160
154
public function createView (ChoiceListInterface $ list , $ preferredChoices = null , $ label = null , $ index = null , $ groupBy = null , $ attr = null )
@@ -175,7 +169,7 @@ public function createView(ChoiceListInterface $list, $preferredChoices = null,
175
169
176
170
if (is_string ($ preferredChoices ) && !is_callable ($ preferredChoices )) {
177
171
$ preferredChoices = new PropertyPath ($ preferredChoices );
178
- } elseif (is_string ($ preferredChoices ) && is_callable ($ preferredChoices )) {
172
+ } elseif (is_string ($ preferredChoices ) && is_callable ($ preferredChoices )) {
179
173
@trigger_error ('createView() - $preferredChoices - treats callable strings as callable and is deprecated since version 3.0. ' , E_USER_DEPRECATED );
180
174
}
181
175
0 commit comments