8000 #17993 - missing space after elseif / don't deprecate the whole method · Simperfit/symfony@96e2921 · GitHub
[go: up one dir, main page]

Skip to content

Commit 96e2921

Browse files
author
hamza
committed
symfony#17993 - missing space after elseif / don't deprecate the whole method
1 parent c087029 commit 96e2921

File tree

1 file changed

+3
-9
lines changed

1 file changed

+3
-9
lines changed

src/Symfony/Component/Form/ChoiceList/Factory/PropertyAccessDecorator.php

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -80,15 +80,13 @@ public function getDecoratedFactory()
8080
* @param null|callable|string|PropertyPath $value The callable or path for
8181
* generating the choice values
8282
*
83-
* @deprecated We should not treat callable strings as callable
84-
*
8583
* @return ChoiceListInterface The choice list
8684
*/
8785
public function createListFromChoices($choices, $value = null)
8886
{
8987
if (is_string($value) && !is_callable($value)) {
9088
$value = new PropertyPath($value);
91-
} elseif(is_string($value) && is_callable($value)) {
89+
} elseif (is_string($value) && is_callable($value)) {
9290
@trigger_error('createListFromChoices() treats callable strings as callable and is deprecated since version 3.0.', E_USER_DEPRECATED);
9391
}
9492

@@ -115,15 +113,13 @@ public function createListFromChoices($choices, $value = null)
115113
* @param null|callable|string|PropertyPath $value The callable or path for
116114
* generating the choice values
117115
*
118-
* @deprecated We should not treat callable strings as callable
119-
*
120116
* @return ChoiceListInterface The choice list
121117
*/
122118
public function createListFromLoader(ChoiceLoaderInterface $loader, $value = null)
123119
{
124120
if (is_string($value) && !is_callable($value)) {
125121
$value = new PropertyPath($value);
126-
} elseif(is_string($value) && is_callable($value)) {
122+
} elseif (is_string($value) && is_callable($value)) {
127123
@trigger_error('createListFromLoader() treats callable strings as callable and is deprecated since version 3.0.', E_USER_DEPRECATED);
128124
}
129125

@@ -153,8 +149,6 @@ public function createListFromLoader(ChoiceLoaderInterface $loader, $value = nul
153149
* @param null|callable|string|PropertyPath $groupBy The callable or path generating the group names
154150
* @param null|array|callable|string|PropertyPath $attr The callable or path generating the HTML attributes
155151
*
156-
* @deprecated We should not treat callable strings as callable
157-
*
158152
* @return ChoiceListView The choice list view
159153
*/
160154
public function createView(ChoiceListInterface $list, $preferredChoices = null, $label = null, $index = null, $groupBy = null, $attr = null)
@@ -175,7 +169,7 @@ public function createView(ChoiceListInterface $list, $preferredChoices = null,
175169

176170
if (is_string($preferredChoices) && !is_callable($preferredChoices)) {
177171
$preferredChoices = new PropertyPath($preferredChoices);
178-
} elseif(is_string($preferredChoices) && is_callable($preferredChoices)) {
172+
} elseif (is_string($preferredChoices) && is_callable($preferredChoices)) {
179173
@trigger_error('createView() - $preferredChoices - treats callable strings as callable and is deprecated since version 3.0.', E_USER_DEPRECATED);
180174
}
181175

0 commit comments

Comments
 (0)
0