8000 FindBugs · Silent-Fred/iTrySQL@8b76bc3 · GitHub
[go: up one dir, main page]
Skip to content

Commit 8b76bc3

Browse files
Silent-FredSilent-Fred
committed
FindBugs
1 parent e730cfa commit 8b76bc3

File tree

6 files changed

+17
-4
lines changed

6 files changed

+17
-4
lines changed

‎src/de/kuehweg/sqltool/dialog/action/ExecuteAction.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ public void attach(final ExecutionTracker... trackers) {
5353
}
5454

5555
public void detach(final ExecutionTracker... trackers) {
56-
this.trackers.remove(Arrays.asList(trackers));
56+
this.trackers.removeAll(Arrays.asList(trackers));
5757
}
5858

5959
public void setLimitMaxRows(final boolean limitMaxRows) {

‎src/de/kuehweg/sqltool/dialog/base/FontSizeZoomable.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,12 @@
2626

2727
package de.kuehweg.sqltool.dialog.base;
2828

29+
import java.io.Serializable;
30+
2931
/**
3032
* @author Michael Kühweg
3133
*/
32-
public interface FontSizeZoomable {
34+
public interface FontSizeZoomable extends Serializable {
3335

3436
int getFontSize();
3537

‎src/de/kuehweg/sqltool/dialog/component/editor/AceBasedEditor.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,8 @@
3737
*/
3838
public class AceBasedEditor implements StatementEditor {
3939

40+
private static final long serialVersionUID = 2399100995033444144L;
41+
4042
public static final String RESOURCE = "/resources/ace/sql_editor.html";
4143

4244
public static final int MIN_FONT_SIZE = 9;

‎src/de/kuehweg/sqltool/dialog/component/editor/CodeMirrorBasedEditor.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,14 @@
3737
*/
3838
public class CodeMirrorBasedEditor implements StatementEditor {
3939

40+
private static final long serialVersionUID = -7122785829568042892L;
41+
4042
public static final String RESOURCE = "/resources/codemirror/sql_editor.html";
4143

4244
private enum FontSizeSteps {
43-
NORMAL(12), MEDIUM(14), BIG(18);
45+
NORMAL(12),
46+
MEDIUM(14),
47+
BIG(18);
4448
private int equivalentFontSize;
4549

4650
FontSizeSteps(final int equivalentFontSize) {

‎src/de/kuehweg/sqltool/dialog/component/editor/StatementEditorCycle.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,12 +26,15 @@
2626

2727
package de.kuehweg.sqltool.dialog.component.editor;
2828

29+
import java.io.Serializable;
2930
import java.util.LinkedList;
3031

3132
/**
3233
* @author Michael Kühweg
3334
*/
34-
public class StatementEditorCycle {
35+
public class StatementEditorCycle implements Serializable {
36+
37+
private static final long serialVersionUID = -8885095183930281907L;
3538

3639
private final LinkedList<Class<? extends StatementEditor>> statementEditorClasses = new LinkedList<>();
3740

‎src/de/kuehweg/sqltool/dialog/component/editor/TextAreaBasedEditor.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,8 @@
3838
*/
3939
public class TextAreaBasedEditor implements StatementEditor {
4040

41+
private static final long serialVersionUID = 2016577950574286339L;
42+
4143
private final TextArea textArea;
4244

4345
private final FontSizeZoomable zoomable;

0 commit comments

Comments
 (0)
0