[RateLimiter] Remove redundant properties

derrabus · derrabus · commit 587d99f44a30 · 2021-07-16T00:07:55.000+02:00
Signed-off-by: Alexander M. Turek &lt;me@derrabus.de&gt;
diff --git a/src/Symfony/Component/RateLimiter/Policy/FixedWindowLimiter.php b/src/Symfony/Component/RateLimiter/Policy/FixedWindowLimiter.php
@@ -29,20 +29,13 @@ final class FixedWindowLimiter implements LimiterInterface
 {
     use ResetLimiterTrait;
 
-    private $id;
     private $limit;
-    private $storage;
 
     /**
      * @var int seconds
      */
     private $interval;
 
-    /**
-     * @var LockInterface
-     */
-    private $lock;
-
     public function __construct(string $id, int $limit, \DateInterval $interval, StorageInterface $storage, LockInterface $lock = null)
     {
         if ($limit < 1) {
diff --git a/src/Symfony/Component/RateLimiter/Policy/SlidingWindowLimiter.php b/src/Symfony/Component/RateLimiter/Policy/SlidingWindowLimiter.php
@@ -37,20 +37,13 @@ final class SlidingWindowLimiter implements LimiterInterface
 {
     use ResetLimiterTrait;
 
-    private $id;
     private $limit;
-    private $storage;
 
     /**
      * @var int seconds
      */
     private $interval;
 
-    /**
-     * @var LockInterface
-     */
-    private $lock;
-
     public function __construct(string $id, int $limit, \DateInterval $interval, StorageInterface $storage, LockInterface $lock = null)
     {
         $this->storage = $storage;
diff --git a/src/Symfony/Component/RateLimiter/Policy/TokenBucketLimiter.php b/src/Symfony/Component/RateLimiter/Policy/TokenBucketLimiter.php
@@ -28,15 +28,8 @@ final class TokenBucketLimiter implements LimiterInterface
 {
     use ResetLimiterTrait;
 
-    private $id;
     private $maxBurst;
     private $rate;
-    private $storage;
-
-    /**
-     * @var LockInterface
-     */
-    private $lock;
 
     public function __construct(string $id, int $maxBurst, Rate $rate, StorageInterface $storage, LockInterface $lock = null)
     {

Original file line number	Diff line number	Diff line change
`@@ -28,15 +28,8 @@ final class TokenBucketLimiter implements LimiterInterface`
`28`	`28`	`{`
`29`	`29`	`use ResetLimiterTrait;`
`30`	`30`
`31`		`- private $id;`
`32`	`31`	`private $maxBurst;`
`33`	`32`	`private $rate;`
`34`		`- private $storage;`
`35`		`-`
`36`		`- /**`
`37`		`- * @var LockInterface`
`38`		`- */`
`39`		`- private $lock;`
`40`	`33`
`41`	`34`	`public function __construct(string $id, int $maxBurst, Rate $rate, StorageInterface $storage, LockInterface $lock = null)`
`42`	`35`	`{`