SciSharp
diff --git a/‎src/TensorFlowNET.Core/NumPy/NDArray.Index.cs
Lines changed: 2 additions & 2 deletions b/‎src/TensorFlowNET.Core/NumPy/NDArray.Index.cs
Lines changed: 2 additions & 2 deletions
diff --git a/‎src/TensorFlowNET.Core/Tensors/SafeStringTensorHandle.cs
Lines changed: 47 additions & 0 deletions b/‎src/TensorFlowNET.Core/Tensors/SafeStringTensorHandle.cs
Lines changed: 47 additions & 0 deletions
diff --git a/‎src/TensorFlowNET.Core/Tensors/SafeTensorHandle.cs
Lines changed: 2 additions & 2 deletions b/‎src/TensorFlowNET.Core/Tensors/SafeTensorHandle.cs
Lines changed: 2 additions & 2 deletions
diff --git a/‎src/TensorFlowNET.Core/Tensors/TStringHandle.cs
Lines changed: 0 additions & 16 deletions b/‎src/TensorFlowNET.Core/Tensors/TStringHandle.cs
Lines changed: 0 additions & 16 deletions
diff --git a/‎src/TensorFlowNET.Core/Tensors/Tensor.String.cs
Lines changed: 3 additions & 3 deletions b/‎src/TensorFlowNET.Core/Tensors/Tensor.String.cs
Lines changed: 3 additions & 3 deletions
diff --git a/‎src/TensorFlowNET.Core/Tensors/Tensor.cs
Lines changed: 0 additions & 12 deletions b/‎src/TensorFlowNET.Core/Tensors/Tensor.cs
Lines changed: 0 additions & 12 deletions
@@ -64,9 +64,9 @@ NDArray GetData(IEnumerable<Slice> slices)
             if (tensor.Handle == null)
             {
                 if (tf.executing_eagerly())
-                    return new NDArray(tensor);
-                else
                     tensor = tf.defaultSession.eval(tensor);
+                else
+                    return new NDArray(tensor);
             }
 
             return new NDArray(tensor);
 
@@ -0,0 +1,47 @@
+using System;
+using System.Collections.Generic;
+using System.Text;
+using Tensorflow.Util;
+
+namespace Tensorflow
+{
+    public sealed class SafeStringTensorHandle : SafeTensorHandle
+    {
+        Shape _shape;
+        SafeTensorHandle _handle;
+        const int TF_TSRING_SIZE = 24;
+
+        protected SafeStringTensorHandle()
+        {
+        }
+
+        public SafeStringTensorHandle(SafeTensorHandle handle, Shape shape)
+            : base(handle.DangerousGetHandle())
+        {
+            _handle = handle;
+            _shape = shape;
+        }
+
+        protected override bool ReleaseHandle()
+        {
+#if TRACK_TENSOR_LIFE
+            print($"Delete StringTensorHandle 0x{handle.ToString("x16")}");
+#endif
+
+            long size = 1;
+            foreach (var s in _shape.dims)
+                size *= s;
+            var tstr = c_api.TF_TensorData(_handle);
+
+            for (int i = 0; i < size; i++)
+            {
+                c_api.TF_StringDealloc(tstr);
+                tstr += TF_TSRING_SIZE;
+            }
+
+            SetHandle(IntPtr.Zero);
+
+            return true;
+        }
+    }
+}
@@ -20,9 +20,9 @@ limitations under the License.
 
 namespace Tensorflow
 {
-    public sealed class SafeTensorHandle : SafeTensorflowHandle
+    public class SafeTensorHandle : SafeTensorflowHandle
     {
-        private SafeTensorHandle()
+        protected SafeTensorHandle()
         {
         }
 
 
@@ -10,7 +10,7 @@ public partial class Tensor
     {
         const int TF_TSRING_SIZE = 24;
 
-        public SafeTensorHandle StringTensor(string[] strings, Shape shape)
+        public SafeStringTensorHandle StringTensor(string[] strings, Shape shape)
         {
             // convert string array to byte[][]
             var buffer = new byte[strings.Length][];
@@ -20,7 +20,7 @@ public SafeTensorHandle StringTensor(string[] strings, Shape shape)
             return StringTensor(buffer, shape);
         }
 
-        public SafeTensorHandle StringTensor(byte[][] buffer, Shape shape)
+        public SafeStringTensorHandle StringTensor(byte[][] buffer, Shape shape)
         {
             var handle = c_api.TF_AllocateTensor(TF_DataType.TF_STRING,
                 shape.ndim == 0 ? null : shape.dims,
@@ -39,7 +39,7 @@ public SafeTensorHandle StringTensor(byte[][] buffer, Shape shape)
                 tstr += TF_TSRING_SIZE;
             }
 
-            return handle;
+            return new SafeStringTensorHandle(handle, shape);
         }
 
         public string[] StringData()
 
@@ -255,19 +255,7 @@ public override string ToString()
 
         protected override void DisposeUnmanagedResources(IntPtr handle)
         {
-            if (dtype == TF_DataType.TF_STRING)
-            {
-                long size = 1;
-                foreach (var s in shape.dims)
-                    size *= s;
-                var tstr = TensorDataPointer;
 
-                for (int i = 0; i < size; i++)
-                {
-                    c_api.TF_StringDealloc(tstr);
-                    tstr += TF_TSRING_SIZE;
-                }
-            }
         }
 
         public bool IsDisposed => _disposed;
Original file line number	Diff line number	Diff line change
`@@ -64,9 +64,9 @@ NDArray GetData(IEnumerable<Slice> slices)`
`64`	`64`	`if (tensor.Handle == null)`
`65`	`65`	`{`
`66`	`66`	`if (tf.executing_eagerly())`
`67`		`- return new NDArray(tensor);`
`68`		`- else`
`69`	`67`	`tensor = tf.defaultSession.eval(tensor);`
	`68`	`+ else`
	`69`	`+ return new NDArray(tensor);`
`70`	`70`	`}`
`71`	`71`
`72`	`72`	`return new NDArray(tensor);`
Original file line number	Diff line number	Diff line change
`@@ -20,9 +20,9 @@ limitations under the License.`
`20`	`20`
`21`	`21`	`namespace Tensorflow`
`22`	`22`	`{`
`23`		`- public sealed class SafeTensorHandle : SafeTensorflowHandle`
	`23`	`+ public class SafeTensorHandle : SafeTensorflowHandle`
`24`	`24`	`{`
`25`		`- private SafeTensorHandle()`
	`25`	`+ protected SafeTensorHandle()`
`26`	`26`	`{`
`27`	`27`	`}`
`28`	`28`
Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@ public partial class Tensor`
`10`	`10`	`{`
`11`	`11`	`const int TF_TSRING_SIZE = 24;`
`12`	`12`
`13`		`- public SafeTensorHandle StringTensor(string[] strings, Shape shape)`
	`13`	`+ public SafeStringTensorHandle StringTensor(string[] strings, Shape shape)`
`14`	`14`	`{`
`15`	`15`	`// convert string array to byte[][]`
`16`	`16`	`var buffer = new byte[strings.Length][];`
`@@ -20,7 +20,7 @@ public SafeTensorHandle StringTensor(string[] strings, Shape shape)`
`20`	`20`	`return StringTensor(buffer, shape);`
`21`	`21`	`}`
`22`	`22`
`23`		`- public SafeTensorHandle StringTensor(byte[][] buffer, Shape shape)`
	`23`	`+ public SafeStringTensorHandle StringTensor(byte[][] buffer, Shape shape)`
`24`	`24`	`{`
`25`	`25`	`var handle = c_api.TF_AllocateTensor(TF_DataType.TF_STRING,`
`26`	`26`	`shape.ndim == 0 ? null : shape.dims,`
`@@ -39,7 +39,7 @@ public SafeTensorHandle StringTensor(byte[][] buffer, Shape shape)`
`39`	`39`	`tstr += TF_TSRING_SIZE;`
`40`	`40`	`}`
`41`	`41`
`42`		`- return handle;`
	`42`	`+ return new SafeStringTensorHandle(handle, shape);`
`43`	`43`	`}`
`44`	`44`
`45`	`45`	`public string[] StringData()`