Saaman
diff --git a/‎LibGit2Sharp/Configuration.cs
Lines changed: 12 additions & 8 deletions b/‎LibGit2Sharp/Configuration.cs
Lines changed: 12 additions & 8 deletions
@@ -134,6 +134,8 @@ public void Dispose()
         /// <param name = "level">The configuration file which should be considered as the target of this operation</param>
         public virtual void Unset(string key, ConfigurationLevel level = ConfigurationLevel.Local)
         {
+            Ensure.ArgumentNotNullOrEmptyString(key, "key");
+
             ConfigurationSafeHandle h = RetrieveConfigurationHandle(level);
 
             bool success = Proxy.git_config_delete(h, key);
@@ -152,6 +154,8 @@ public virtual void Unset(string key, ConfigurationLevel level = ConfigurationLe
         [Obsolete("This method will be removed in the next release. Please use Unset() instead.")]
         public void Delete(string key, ConfigurationLevel level = ConfigurationLevel.Local)
         {
+            Ensure.ArgumentNotNullOrEmptyString(key, "key");
+
             Unset(key, level);
         }
 
@@ -221,8 +225,8 @@ public virtual T Get<T>(string key, T defaultValue)
         [Obsolete("This method will be removed in the next release. Please use a different overload instead.")]        
         public virtual T Get<T>(string firstKeyPart, string secondKeyPart, T defaultValue)
         {
-            Ensure.ArgumentNotNull(firstKeyPart, "firstKeyPart");
-            Ensure.ArgumentNotNull(secondKeyPart, "secondKeyPart");
+            Ensure.ArgumentNotNullOrEmptyString(firstKeyPart, "firstKeyPart");
+            Ensure.ArgumentNotNullOrEmptyString(secondKeyPart, "secondKeyPart");
 
             return Get(new[] { firstKeyPart, secondKeyPart }, defaultValue);
         }
@@ -253,9 +257,9 @@ public virtual T Get<T>(string firstKeyPart, string secondKeyPart, T defaultValu
         [Obsolete("This method will be removed in the next release. Please use a different overload instead.")]
         public virtual T Get<T>(string firstKeyPart, string secondKeyPart, string thirdKeyPart, T defaultValue)
         {
-            Ensure.ArgumentNotNull(firstKeyPart, "firstKeyPart");
-            Ensure.ArgumentNotNull(secondKeyPart, "secondKeyPart");
-            Ensure.ArgumentNotNull(thirdKeyPart, "secondKeyPart");
+            Ensure.ArgumentNotNullOrEmptyString(firstKeyPart, "firstKeyPart");
+            Ensure.ArgumentNotNullOrEmptyString(secondKeyPart, "secondKeyPart");
+            Ensure.ArgumentNotNullOrEmptyString(thirdKeyPart, "secondKeyPart");
 
             return Get(new[] { firstKeyPart, secondKeyPart, thirdKeyPart }, defaultValue);
         }
@@ -374,9 +378,9 @@ public ConfigurationEntry<T> Get<T>(string[] keyParts)
         /// <returns>The <see cref="ConfigurationEntry{T}"/>, or null if not set</returns>
         public ConfigurationEntry<T> Get<T>(string firstKeyPart, string secondKeyPart, string thirdKeyPart)
         {
-            Ensure.ArgumentNotNull(firstKeyPart, "firstKeyPart");
-            Ensure.ArgumentNotNull(secondKeyPart, "secondKeyPart");
-            Ensure.ArgumentNotNull(thirdKeyPart, "secondKeyPart");
+            Ensure.ArgumentNotNullOrEmptyString(firstKeyPart, "firstKeyPart");
+            Ensure.ArgumentNotNullOrEmptyString(secondKeyPart, "secondKeyPart");
+            Ensure.ArgumentNotNullOrEmptyString(thirdKeyPart, "secondKeyPart");
 
             return Get<T>(new[] { firstKeyPart, secondKeyPart, thirdKeyPart });
         }
Original file line number	Diff line number	Diff line change
`@@ -134,6 +134,8 @@ public void Dispose()`
`134`	`134`	`/// <param name = "level">The configuration file which should be considered as the target of this operation</param>`
`135`	`135`	`public virtual void Unset(string key, ConfigurationLevel level = ConfigurationLevel.Local)`
`136`	`136`	`{`
	`137`	`+ Ensure.ArgumentNotNullOrEmptyString(key, "key");`
	`138`	`+`
`137`	`139`	`ConfigurationSafeHandle h = RetrieveConfigurationHandle(level);`
`138`	`140`
`139`	`141`	`bool success = Proxy.git_config_delete(h, key);`
`@@ -152,6 +154,8 @@ public virtual void Unset(string key, ConfigurationLevel level = ConfigurationLe`
`152`	`154`	`[Obsolete("This method will be removed in the next release. Please use Unset() instead.")]`
`153`	`155`	`public void Delete(string key, ConfigurationLevel level = ConfigurationLevel.Local)`
`154`	`156`	`{`
	`157`	`+ Ensure.ArgumentNotNullOrEmptyString(key, "key");`
	`158`	`+`
`155`	`159`	`Unset(key, level);`
`156`	`160`	`}`
`157`	`161`
`@@ -221,8 +225,8 @@ public virtual T Get<T>(string key, T defaultValue)`
`221`	`225`	`[Obsolete("This method will be removed in the next release. Please use a different overload instead.")]`
`222`	`226`	`public virtual T Get<T>(string firstKeyPart, string secondKeyPart, T defaultValue)`
`223`	`227`	`{`
`224`		`- Ensure.ArgumentNotNull(firstKeyPart, "firstKeyPart");`
`225`		`- Ensure.ArgumentNotNull(secondKeyPart, "secondKeyPart");`
	`228`	`+ Ensure.ArgumentNotNullOrEmptyString(firstKeyPart, "firstKeyPart");`
	`229`	`+ Ensure.ArgumentNotNullOrEmptyString(secondKeyPart, "secondKeyPart");`
`226`	`230`
`227`	`231`	`return Get(new[] { firstKeyPart, secondKeyPart }, defaultValue);`
`228`	`232`	`}`
`@@ -253,9 +257,9 @@ public virtual T Get<T>(string firstKeyPart, string secondKeyPart, T defaultValu`
`253`	`257`	`[Obsolete("This method will be removed in the next release. Please use a different overload instead.")]`
`254`	`258`	`public virtual T Get<T>(string firstKeyPart, string secondKeyPart, string thirdKeyPart, T defaultValue)`
`255`	`259`	`{`
`256`		`- Ensure.ArgumentNotNull(firstKeyPart, "firstKeyPart");`
`257`		`- Ensure.ArgumentNotNull(secondKeyPart, "secondKeyPart");`
`258`		`- Ensure.ArgumentNotNull(thirdKeyPart, "secondKeyPart");`
	`260`	`+ Ensure.ArgumentNotNullOrEmptyString(firstKeyPart, "firstKeyPart");`
	`261`	`+ Ensure.ArgumentNotNullOrEmptyString(secondKeyPart, "secondKeyPart");`
	`262`	`+ Ensure.ArgumentNotNullOrEmptyString(thirdKeyPart, "secondKeyPart");`
`259`	`263`
`260`	`264`	`return Get(new[] { firstKeyPart, secondKeyPart, thirdKeyPart }, defaultValue);`
`261`	`265`	`}`
`@@ -374,9 +378,9 @@ public ConfigurationEntry<T> Get<T>(string[] keyParts)`
`374`	`378`	`/// <returns>The <see cref="ConfigurationEntry{T}"/>, or null if not set</returns>`
`375`	`379`	`public ConfigurationEntry<T> Get<T>(string firstKeyPart, string secondKeyPart, string thirdKeyPart)`
`376`	`380`	`{`
`377`		`- Ensure.ArgumentNotNull(firstKeyPart, "firstKeyPart");`
`378`		`- Ensure.ArgumentNotNull(secondKeyPart, "secondKeyPart");`
`379`		`- Ensure.ArgumentNotNull(thirdKeyPart, "secondKeyPart");`
	`381`	`+ Ensure.ArgumentNotNullOrEmptyString(firstKeyPart, "firstKeyPart");`
	`382`	`+ Ensure.ArgumentNotNullOrEmptyString(secondKeyPart, "secondKeyPart");`
	`383`	`+ Ensure.ArgumentNotNullOrEmptyString(thirdKeyPart, "secondKeyPart");`
`380`	`384`
`381`	`385`	`return Get<T>(new[] { firstKeyPart, secondKeyPart, thirdKeyPart });`
`382`	`386`	`}`