8000 feat: Detect sap/ui/core/plugin/DeclarativeSupport and sap/ui/core/plugin/LessSupport by d3xter666 · Pull Request #328 · SAP/ui5-linter · GitHub
[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Detect sap/ui/core/plugin/DeclarativeSupport and sap/ui/core/plugin/LessSupport #328

Merged
merged 12 commits into from
Sep 30, 2024
Merged

feat: Detect sap/ui/core/plugin/DeclarativeSupport and sap/ui/core/plugin/LessSupport #328

merged 12 commits into from
Sep 30, 2024

Conversation

d3xter666
Copy link
Contributor

JIRA: CPOUI5FOUNDATION-905

@d3xter666 d3xter666 marked this pull request as draft September 30, 2024 07:24
@flovogt flovogt changed the title feat: Detect declarative & LESS support feat: Detect sap/ui/core/plugin/DeclarativeSupport & sap/ui/core/plugin/LessSupport Sep 30, 2024
@flovogt flovogt changed the title feat: Detect sap/ui/core/plugin/DeclarativeSupport & sap/ui/core/plugin/LessSupport feat: Detect sap/ui/core/plugin/DeclarativeSupport and sap/ui/core/plugin/LessSupport Sep 30, 2024
@d3xter666 d3xter666 marked this pull request as ready for review September 30, 2024 08:52
@d3xter666 d3xter666 requested a review from a team September 30, 2024 08:52
flovogt
flovogt reviewed Sep 30, 2024
View reviewed changes
@flovogt flovogt 8000 requested a review from a team September 30, 2024 09:14
d3xter666 and others added 2 commits September 30, 2024 12:35
@d3xter666 @flovogt
refactor: Update src/linter/messages.ts
86e78fc 
Co-authored-by: Florian Vogt <florian.vogt@sap.com>
@d3xter666
test: Update snapshots
9122984
@d3xter666 d3xter666 requested a review from flovogt September 30, 2024 11:13
flovogt
flovogt reviewed Sep 30, 2024
View reviewed changes
flovogt
flovogt reviewed Sep 30, 2024
View reviewed changes
flovogt
flovogt reviewed Sep 30, 2024
View reviewed changes
KlattG
KlattG suggested changes Sep 30, 2024
View reviewed changes
Copy link
Contributor
@KlattG KlattG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor suggestions, otherwise fine.

RandomByte
RandomByte reviewed Sep 30, 2024
View reviewed changes
RandomByte
RandomByte reviewed Sep 30, 2024
View reviewed changes
Copy link
Member
@RandomByte RandomByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion but otherwise looks good to me

@RandomByte RandomByte force-pushed the feat-detect-declarative-support branch from 19a8941 to 7edae33 Compare September 30, 2024 13:33
@flovogt flovogt merged commit 6545780 into main Sep 30, 2024
13 checks passed
@flovogt flovogt deleted the feat-detect-declarative-support branch September 30, 2024 13:46
@openui5bot openui5bot mentioned this pull request Sep 30, 2024
Merged
maxreichmann pushed a commit that referenced this pull request Oct 2, 2024
@d3xter666 @RandomByte
@flovogt @maxreichmann
feat: Detect sap/ui/core/plugin/DeclarativeSupport and sap/ui/core/pl…
bfd01b4 
…ugin/LessSupport (#328)

JIRA: CPOUI5FOUNDATION-905

---------

Co-authored-by: Merlin Beutlberger <m.beutlberger@sap.com>
Co-authored-by: Florian Vogt <florian.vogt@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RandomByte RandomByte RandomByte approved these changes

@KlattG KlattG KlattG requested changes

@flovogt flovogt flovogt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@d3xter666 @RandomByte @flovogt @KlattG
0