10000 datetime().astimezone() is broken · Issue #4982 · RustPython/RustPython · GitHub
[go: up one dir, main page]
Skip to content

datetime().astimezone() is broken #4982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xiaxinmeng opened this issue May 20, 2023 · 1 comment · Fixed by #5391
Closed

datetime().astimezone() is broken #4982

xiaxinmeng opened this issue May 20, 2023 · 1 comment · Fixed by #5391
Labels
A-stdlib C-bug Something isn't working

Comments

@xiaxinmeng
Copy link

It seems that RustPython supports datetime().astimezone() while the implementation of this function is broken and attribute 'tm_gmtoff' is missing. See the following example.

Example.py

from datetime import datetime
datetime(3001, 1, 19, 7, 59, 59, 999999).astimezone()

Output on RustPython:

Traceback (most recent call last):
  File "/home/xxm/Desktop/RustPython/example.py", line 199, in <module>
    datetime(3001, 1, 19, 7, 59, 59, 999999).astimezone() 
  File "/home/xxm/.cargo/git/checkouts/rustpython-f8ef4d934ac33cd8/59df92d/pylib/Lib/datetime.py", line 1862, in astimezone
    tz = self._local_timezone()
  File "/home/xxm/.cargo/git/checkouts/rustpython-f8ef4d934ac33cd8/59df92d/pylib/Lib/datetime.py", line 1856, in _local_timezone
    gmtoff = localtm.tm_gmtoff
AttributeError: 'struct_time' object has no attribute 'tm_gmtoff'

Behavior on CPython: works normally

Environment:
RustPython: v0.2.0 (https://github.com/RustPython/RustPython#59df92d7)
CPython: 3.9.0
Ubuntu 18.04
@DimitrisJim DimitrisJim added C-bug Something isn't working A-stdlib labels May 20, 2023
@DimitrisJim
Copy link
Member

both tm_gmtoff and tm_zone are missing from the struct_time struct:

RustPython/vm/src/stdlib/time.rs

Lines 318 to 328 in 59df92d

struct PyStructTime {
tm_year: PyObjectRef,
tm_mon: PyObjectRef,
tm_mday: PyObjectRef,
tm_hour: PyObjectRef,
tm_min: PyObjectRef,
tm_sec: PyObjectRef,
tm_wday: PyObjectRef,
tm_yday: PyObjectRef,
tm_isdst: PyObjectRef,
}

reference, Python docs on these: https://docs.python.org/3/library/time.html#time.struct_time

Might be easy to add them.

@bobby-palmer bobby-palmer mentioned this issue Jun 19, 2023
Closed
@JazzGlobal JazzGlobal mentioned this issue Aug 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-stdlib C-bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

4982 - Implement tm_gmtoff and tm_zone JazzGlobal/RustPython
2 participants
@DimitrisJim @xiaxinmeng
0