Fix macos shutil

youknowone · youknowone · commit e7bfbcc1f02d · 2024-04-20T04:27:35.000+09:00
diff --git a/Lib/test/test_shutil.py b/Lib/test/test_shutil.py
@@ -1088,8 +1088,6 @@ def test_copymode_follow_symlinks(self):
         shutil.copymode(src_link, dst_link)
         self.assertEqual(os.stat(src).st_mode, os.stat(dst).st_mode)
 
-    # TODO: RUSTPYTHON
-    @unittest.expectedFailure
     @unittest.skipUnless(hasattr(os, 'lchmod') or os.name == 'nt', 'requires os.lchmod')
     @os_helper.skip_unless_symlink
     def test_copymode_symlink_to_symlink(self):
@@ -3008,7 +3006,6 @@ def test_unhandled_exception(self):
             self.assertRaises(ZeroDivisionError,
                               shutil.copyfile, TESTFN, TESTFN2)
 
-    @unittest.skipIf(sys.platform == "darwin", "TODO: RUSTPYTHON, OSError.error on macOS")
     def test_exception_on_first_call(self):
         # Emulate a case where the first call to the zero-copy
         # function raises an exception in which case the function is
@@ -3019,7 +3016,6 @@ def test_exception_on_first_call(self):
                 with self.assertRaises(_GiveupOnFastCopy):
                     self.zerocopy_fun(src, dst)
 
-    @unittest.skipIf(sys.platform == "darwin", "TODO: RUSTPYTHON, OSError.error on macOS")
     def test_filesystem_full(self):
         # Emulate a case where filesystem is full and sendfile() fails
         # on first call.
diff --git a/vm/src/stdlib/posix.rs b/vm/src/stdlib/posix.rs
@@ -966,7 +966,16 @@ pub mod module {
     #[cfg(not(target_os = "redox"))]
     #[pyfunction]
     fn lchmod(path: OsPath, mode: u32, vm: &VirtualMachine) -> PyResult<()> {
-        _chmod(path, DirFd::default(), mode, FollowSymlinks(false), vm)
+        extern "C" {
+            fn lchmod(path: *const libc::c_char, mode: libc::mode_t) -> libc::c_int;
+        }
+        let c_path = path.clone().into_cstring(vm)?;
+        if unsafe { lchmod(c_path.as_ptr(), mode as libc::mode_t) } == 0 {
+            Ok(())
+        } else {
+            let err = std::io::Error::last_os_error();
+            Err(IOErrorBuilder::with_filename(&err, path, vm))
+        }
     }
 
     #[pyfunction]
