8000 Merge pull request #5191 from dchiquito/fix-failing-tests · RustPython/RustPython@d453026 · GitHub
[go: up one dir, main page]
Skip to content

Commit d453026

Browse files
youknowoneyouknowone
authored
Merge pull request #5191 from dchiquito/fix-failing-tests
Fix convenient failing tests
2 parents 2fde8e9 + 23ebbd0 commit d453026

File tree

3 files changed

+9
-1
lines changed

3 files changed

+9
-1
lines changed

‎Lib/test/test_cmd_line.py‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -411,7 +411,8 @@ def test_empty_PYTHONPATH_issue16309(self):
411411
path = ":".join(sys.path)
412412
path = path.encode("ascii", "backslashreplace")
413413
sys.stdout.buffer.write(path)"""
414-
rc1, out1, err1 = assert_python_ok('-c', code, PYTHONPATH="")
414+
# TODO: RUSTPYTHON we must unset RUSTPYTHONPATH as well
415+
rc1, out1, err1 = assert_python_ok('-c', code, PYTHONPATH="", RUSTPYTHONPATH="")
415416
rc2, out2, err2 = assert_python_ok('-c', code, __isolated=False)
416417
# regarding to Posix specification, outputs should be equal
417418
# for empty and unset PYTHONPATH

‎Lib/test/test_format.py‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -420,6 +420,9 @@ def test_non_ascii(self):
420420
self.assertEqual(format(1+2j, "\u2007^8"), "\u2007(1+2j)\u2007")
421421
self.assertEqual(format(0j, "\u2007^4"), "\u20070j\u2007")
422422

423+
# TODO: RUSTPYTHON formatting does not support locales
424+
# See https://github.com/RustPython/RustPython/issues/5181
425+
@unittest.skip("formatting does not support locales")
423426
def test_locale(self):
424427
try:
425428
oldloc = locale.setlocale(locale.LC_ALL)

‎Lib/test/test_socket.py‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2161,12 +2161,16 @@ def testCreateISOTPSocket(self):
21612161
with socket.socket(socket.PF_CAN, socket.SOCK_DGRAM, socket.CAN_ISOTP) as s:
21622162
pass
21632163

2164+
# TODO: RUSTPYTHON, OSError: bind(): bad family
2165+
@unittest.expectedFailure
21642166
def testTooLongInterfaceName(self):
21652167
# most systems limit IFNAMSIZ to 16, take 1024 to be sure
21662168
with socket.socket(socket.PF_CAN, socket.SOCK_DGRAM, socket.CAN_ISOTP) as s:
21672169
with self.assertRaisesRegex(OSError, 'interface name too long'):
21682170
s.bind(('x' * 1024, 1, 2))
21692171

2172+
# TODO: RUSTPYTHON, OSError: bind(): bad family
2173+
@unittest.expectedFailure
21702174
def testBind(self):
21712175
try:
21722176
with socket.socket(socket.PF_CAN, socket.SOCK_DGRAM, socket.CAN_ISOTP) as s:

0 commit comments

Comments
 (0)
0