8000 keep test expectedFailure in general · RustPython/RustPython@d013ffd · GitHub
[go: up one dir, main page]
Skip to content

Commit d013ffd

Browse files
Blues-starBlues-star
committed
keep test expectedFailure in general
1 parent 001f896 commit d013ffd

File tree

1 file changed

+39
-29
lines changed

1 file changed

+39
-29
lines changed

‎Lib/test/test_csv.py

Lines changed: 39 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -176,6 +176,7 @@ def test_write_bigfield(self):
176176
bigstring = 'X' * 50000
177177
self._write_test([bigstring,bigstring], '%s,%s' % \
178178
(bigstring, bigstring))
179+
179180
# TODO: RUSTPYTHON quoting style check is unsupported
180181
@unittest.expectedFailure
181182
def test_write_quoting(self):
@@ -227,6 +228,7 @@ def test_write_escape(self):
227228
escapechar='\\', quoting=csv.QUOTE_MINIMAL)
228229
self._write_test(['C\\', '6', '7', 'X"'], 'C\\\\,6,7,"X"""',
229230
escapechar='\\', quoting=csv.QUOTE_MINIMAL)
231+
230232
# TODO: RUSTPYTHON lineterminator double char unsupported
231233
@unittest.expectedFailure
232234
def test_write_lineterminator(self):
@@ -239,6 +241,7 @@ def test_write_lineterminator(self):
239241
self.assertEqual(sio.getvalue(),
240242
f'a,b{lineterminator}'
241243
f'1,2{lineterminator}')
244+
242245
# TODO: RUSTPYTHON ''\r\n to ""\r\n unspported
243246
@unittest.expectedFailure
244247
def test_write_iterable(self):
@@ -305,12 +308,13 @@ def _read_test(self, input, expect, **kwargs):
305308
result = list(reader)
306309
self.assertEqual(result, expect)
307310

311+
# TODO RUSTPYTHON strict mode is unsupported
312+
@unittest.expectedFailure
308313
def test_read_oddinputs(self):
309314
self._read_test([], [])
310315
self._read_test([''], [[]])
311-
# TODO RUSTPYTHON strict mode is unsupported
312-
# self.assertRaises(csv.Error, self._read_test,
313-
# ['"ab"c'], None, strict = 1)
316+
self.assertRaises(csv.Error, self._read_test,
317+
['"ab"c'], None, strict = 1)
314318
self._read_test(['"ab"c'], [['abc']], doublequote = 0)
315319

316320
self.assertRaises(csv.Error, self._read_test,
@@ -324,6 +328,7 @@ def test_read_eol(self):
324328
self.assertRaises(csv.Error, self._read_test, ['a,b\rc,d'], [])
325329
self.assertRaises(csv.Error, self._read_test, ['a,b\nc,d'], [])
326330
self.assertRaises(csv.Error, self._read_test, ['a,b\r\nc,d'], [])
331+
327332
# TODO RUSTPYTHON double quote umimplement
328333
@unittest.expectedFailure
329334
def test_read_eof(self):
@@ -335,12 +340,13 @@ def test_read_eof(self):
335340
self.assertRaises(csv.Error, self._read_test,
336341
['^'], [], escapechar='^', strict=True)
337342

343+
# TODO RUSTPYTHON
344+
@unittest.expectedFailure
338345
def test_read_nul(self):
339346
self._read_test(['\0'], [['\0']])
340347
self._read_test(['a,\0b,c'], [['a', '\0b', 'c']])
341348
self._read_test(['a,b\0,c'], [['a', 'b\0', 'c']])
342-
# TODO RUSTPYTHON
343-
# self._read_test(['a,b\\\0,c'], [['a', 'b\0', 'c']], escapechar='\\')
349+
self._read_test(['a,b\\\0,c'], [['a', 'b\0', 'c']], escapechar='\\')
344350
self._read_test(['a,"\0b",c'], [['a', '\0b', 'c']])
345351

346352
def test_read_delimiter(self):
@@ -548,16 +554,16 @@ class unspecified():
548554

549555
csv.register_dialect('testC', testC)
550556
try:
551-
# self.compare_dialect_123("1,2,3\r\n")
552-
# self.compare_dialect_123("1,2,3\r\n", dialect=None)
553-
# self.compare_dialect_123("1,2,3\r\n", dialect=unspecified)
554-
# self.compare_dialect_123("1\t2\t3\r\n", testA)
555-
# self.compare_dialect_123("1:2:3\r\n", dialect=testB())
556-
# self.compare_dialect_123("1|2|3\r\n", dialect='testC')
557-
self.compare_dialect_123("1;2;3\r\n", dialect=testA,delimiter=';')
558-
# TODO: RUSTPYTHON
559-
# self.compare_dialect_123("1\u039B2\u039B3\r\n",
560-
# dialect=testUni)
557+
self.compare_dialect_123("1,2,3\r\n")
558+
self.compare_dialect_123("1,2,3\r\n", dialect=None)
559+
self.compare_dialect_123("1,2,3\r\n", dialect=unspecified)
560+
self.compare_dialect_123("1\t2\t3\r\n", testA)
561+
self.compare_dialect_123("1:2:3\r\n", dialect=testB())
562+
self.compare_dialect_123("1|2|3\r\n", dialect='testC')
563+
self.compare_dialect_123("1;2;3\r\n", dialect=testA,
564+
delimiter=';')
565+
self.compare_dialect_123("1\u039B2\u039B3\r\n",
566+
dialect=testUni)
561567

562568
finally:
563569
csv.unregister_dialect('testC')
@@ -610,7 +616,7 @@ def test_simple(self):
610616

611617
def test_blankline(self):
612618
self.readerAssertEqual('', [])
613-
619+
614620
def test_empty_fields(self):
615621
self.readerAssertEqual(',', [['', '']])
616622

@@ -662,6 +668,7 @@ def test_quoted_quote(self):
662668
[['1', '2', '3',
663669
'"I see," said the blind man',
664670
'as he picked up his hammer and saw']])
671+
665672
# Rustpython TODO
666673
@unittest.expectedFailure
667674
def test_quoted_nl(self):
@@ -703,10 +710,12 @@ class EscapedExcel(csv.excel):
703710

704711
class TestEscapedExcel(TestCsvBase):
< F438 /code>
705712
dialect = EscapedExcel()
713+
706714
# TODO RUSTPYTHON
707715
@unittest.expectedFailure
708716
def test_escape_fieldsep(self):
709717
self.writerAssertEqual([['abc,def']], 'abc\\,def\r\n')
718+
710719
# TODO RUSTPYTHON
711720
@unittest.expectedFailure
712721
def test_read_escape_fieldsep(self):
@@ -732,6 +741,7 @@ class TestQuotedEscapedExcel(TestCsvBase):
732741

733742
def test_write_escape_fieldsep(self):
734743
self.writerAssertEqual([['abc,def']], '"abc,def"\r\n')
744+
735745
# TODO RUSTPYTHON
736746
@unittest.expectedFailure
737747
def test_read_escape_fieldsep(self):
@@ -929,6 +939,7 @@ def test_read_multi(self):
929939
"i2": '17',
930940
"s1": 'abc',
931941
"s2": 'def'})
942+
932943
# TODO RUSTPYTHON
933944
@unittest.expectedFailure
934945
def test_read_with_blanks(self):
@@ -1002,19 +1013,19 @@ class mydialect(csv.Dialect):
10021013
skipinitialspace = True
10031014
lineterminator = '\r\n'
10041015
quoting = csv.QUOTE_NONE
1005-
# d = mydialect()
1006-
# self.assertEqual(d.quoting, csv.QUOTE_NONE)
1016+
d = mydialect()
1017+
self.assertEqual(d.quoting, csv.QUOTE_NONE)
10071018

1008-
# mydialect.quoting = None
1009-
# self.assertRaises(csv.Error, mydialect)
1019+
mydialect.quoting = None
1020+
self.assertRaises(csv.Error, mydialect)
10101021

1011-
# mydialect.doublequote = True
1012-
# mydialect.quoting = csv.QUOTE_ALL
1013-
# mydialect.quotechar = '"'
1014-
# d = mydialect()
1015-
# self.assertEqual(d.quoting, csv.QUOTE_ALL)
1016-
# self.assertEqual(d.quotechar, '"')
1017-
# self.assertTrue(d.doublequote)
1022+
mydialect.doublequote = True
1023+
mydialect.quoting = csv.QUOTE_ALL
1024+
mydialect.quotechar = '"'
1025+
d = mydialect()
1026+
self.assertEqual(d.quoting, csv.QUOTE_ALL)
1027+
self.assertEqual(d.quotechar, '"')
1028+
self.assertTrue(d.doublequote)
10181029

10191030
mydialect.quotechar = ""
10201031
with self.assertRaises(csv.Error) as cm:
@@ -1423,8 +1434,7 @@ def test_ordered_dict_reader(self):
14231434
Under1
14241435
John,Cleese
14251436
''').splitlines()
1426-
1427-
print(list(csv.DictReader(data)))
1437+
14281438
self.assertEqual(list(csv.DictReader(data)),
14291439
[OrderedDict([('FirstName', 'Eric'), ('LastName', 'Idle')]),
14301440
OrderedDict([('FirstName', 'Graham'), ('LastName', 'Chapman'),

0 commit comments

Comments
 (0)
0