E568 Apply suggestions from code review with AI assistant · RustPython/RustPython@b87cb8a · GitHub
[go: up one dir, main page]
Skip to content

Commit b87cb8a

Browse files
reactive-firewallcoderabbitai[bot]
reactive-firewall
and
coderabbitai[bot]
authored
Apply suggestions from code review with AI assistant
 Minor changes to defaults and fallback logic as discussed with AI reviewer. Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
1 parent 64728df commit b87cb8a

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

‎.github/actions/CI-5974-Fetch-CPython/action.yaml‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,13 +11,14 @@ inputs:
1111
The GitHub repository to clone CPython from. When running this action on github.com,
1212
the default value is sufficient. Useful for Forks.
1313
required: true
14-
default: ${{ github.server_url == 'https://github.com' && github.repository || 'python/cpython' }}
14+
# keep it simple
15+
default: 'python/cpython'
1516
override-rustpython-path:
1617
description: |
1718
override value for path to the Python Lib. The default is to use the value of the environment
1819
variable 'RUSTPYTHONPATH'. Most users will find the default 'Lib' sufficient.
1920
required: true
20-
default: ${{ github.server_url == 'https://github.com' && github.repository || 'Lib' }}
21+
default: ${{ github.server_url == 'https://github.com' && env.RUSTPYTHONPATH || 'Lib' }}
2122
override-path:
2223
description: |
2324
Path to setup. When running this action on github.com, the default value
@@ -30,7 +31,7 @@ inputs:
3031
environment variable 'PYTHONPLATLIBDIR'. Most users will find the default 'Lib' sufficient.
3132
See https://docs.python.org/3/using/cmdline.html#envvar-PYTHONPLATLIBDIR for more.
3233
required: true
33-
default: ${{ github.server_url == 'https://github.com' && github.repository || 'Lib' }}
34+
default: ${{ github.server_url == 'https://github.com' && env.PYTHONPLATLIBDIR || 'Lib' }}
3435
match:
3536
description: |
3637
Glob-style pattern of files or directories to match and integrate.

‎.github/actions/CI-5974-Fetch-RustPython/action.yaml‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,14 @@ inputs:
1717
The GitHub repository to clone RustPython from. When running this action on github.com,
1818
the default value is sufficient. Useful for Forks.
1919
required: true
20+
# odd as it looks this is correct
2021
default: ${{ github.server_url == 'https://github.com' && github.repository || 'RustPython/RustPython' }}
2122
override-rustpython-path:
2223
description: |
2324
override value for path to the Python Lib. The default is to use the value of the environment
2425
variable 'RUSTPYTHONPATH'. Most users will find the default 'Lib' sufficient.
2526
required: true
26-
default: ${{ github.server_url == 'https://github.com' && github.repository || 'Lib' }}
27+
default: ${{ github.server_url == 'https://github.com' && env.RUSTPYTHONPATH || 'Lib' }}
2728
override-path:
2829
description: |
2930
Path to setup. When running this action on github.com, the default value
@@ -46,11 +47,9 @@ outputs:
4647
description: "The SHA of the commit checked-out."
4748
value: ${{ steps.output_sha.outputs.sha || 'HEAD' }}
4849
rustpython-version:
49-
description: "The python version that was used in the run."
50-
value: '0.4' # TODO: fix this
5150
rustpython-lib-path:
5251
description: "The python version that was used in the run."
53-
value: ${{ steps.output_rpython_path.output.rustpython-lib-path }}
52+
value: ${{ steps.output_rpython_path.outputs.rustpython-lib-path }}
5453

5554
runs:
5655
using: composite

‎.github/actions/CI-5974-Test-RustPython-Integration/action.yaml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ runs:
5656
fi
5757
if [[ -n $OVERRIDE_RUSTPYTHONPATH_INPUT ]]; then
5858
printf "override-rustpython-path=%s\n" "${OVERRIDE_RUSTPYTHONPATH_INPUT}" >> "$GITHUB_OUTPUT"
59-
OVERRIDE_RUSTPYTHONPATH=${RUSTPYTHONPATH}
59+
OVERRIDE_RUSTPYTHONPATH=${OVERRIDE_RUSTPYTHONPATH_INPUT}
6060
else
6161
printf "override-rustpython-path=%s\n" "${RUSTPYTHONPATH:-Lib}" >> "$GITHUB_OUTPUT"
6262
OVERRIDE_RUSTPYTHONPATH="${RUSTPYTHONPATH:-Lib}"

0 commit comments

Comments
 (0)
0