8000 Write message for todo! macro · RustPython/RustPython@5b5b468 · GitHub
[go: up one dir, main page]

Skip to content

Commit 5b5b468

Browse files
committed
Write message for todo! macro
1 parent 29d014a commit 5b5b468

File tree

4 files changed

+19
-7
lines changed

4 files changed

+19
-7
lines changed

compiler/codegen/src/compile.rs

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1095,8 +1095,12 @@ impl Compiler {
10951095
self.store_name(name.as_ref())?;
10961096
}
10971097
}
1098-
located_ast::TypeParam::ParamSpec(_) => todo!(),
1099-
located_ast::TypeParam::TypeVarTuple(_) => todo!(),
1098+
located_ast::TypeParam::ParamSpec(_) => {
1099+
todo!("implement Compiler::compile_type_params for TypeParam::ParamSpec")
1100+
}
1101+
located_ast::TypeParam::TypeVarTuple(_) => {
1102+
todo!("implement Compiler::compile_type_params for TypeParam::TypeVarTuple")
1103+
}
11001104
};
11011105
}
11021106
emit!(

compiler/codegen/src/symboltable.rs

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1257,8 +1257,12 @@ impl SymbolTableBuilder {
12571257
self.scan_expression(binding, ExpressionContext::Load)?;
12581258
}
12591259
}
1260-
ast::located::TypeParam::ParamSpec(_) => todo!(),
1261-
ast::located::TypeParam::TypeVarTuple(_) => todo!(),
1260+
ast::located::TypeParam::ParamSpec(_) => {
1261+
todo!("implement SymbolTableBuilder::scan_type_params TypeParam:::ParamSpec")
1262+
}
1263+
ast::located::TypeParam::TypeVarTuple(_) => {
1264+
todo!("implement SymbolTableBuilder::scan_type_params TypeParam:::TypeVarTuple")
1265+
}
12621266
}
12631267
}
12641268
Ok(())

stdlib/src/csv.rs

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -433,8 +433,12 @@ mod _csv {
433433
QuoteStyle::All => csv_core::QuoteStyle::Always,
434434
QuoteStyle::Nonnumeric => csv_core::QuoteStyle::NonNumeric,
435435
QuoteStyle::None => csv_core::QuoteStyle::Never,
436-
QuoteStyle::Strings => todo!(),
437-
QuoteStyle::Notnull => todo!(),
436+
QuoteStyle::Strings => {
437+
todo!("implement From<QuoteStyle> for csv_core::QuoteStyle::Strings")
438+
}
439+
QuoteStyle::Notnull => {
440+
todo!("implement From<QuoteStyle> for csv_core::QuoteStyle::Notnull")
441+
}
438442
}
439443
}
440444
}

vm/src/builtins/bool.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ impl PyPayload for PyBool {
8888

8989
impl Debug for PyBool {
9090
fn fmt(&self, _f: &mut Formatter<'_>) -> std::fmt::Result {
91-
todo!()
91+
todo!("implement Debug::fmt for PyBool")
9292
}
9393
}
9494

0 commit comments

Comments
 (0)
0