Implement windows platform target is_junction with junction library

moreal · moreal · commit 4d11adfc7271 · 2024-04-16T23:21:17.000+09:00
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/vm/Cargo.toml b/vm/Cargo.toml
@@ -106,6 +106,9 @@ schannel = { workspace = true }
 widestring = { workspace = true }
 winreg = "0.10.1"
 
+[target.'cfg(windows)'.dependencies.junction]
+version = "1.0.0"
+
 [target.'cfg(windows)'.dependencies.windows]
 version = "0.52.0"
 features = [
diff --git a/vm/src/stdlib/os.rs b/vm/src/stdlib/os.rs
@@ -743,13 +743,10 @@ pub(super) mod _os {
             Ok(false)
         }
 
-        // TODO: RUSTPYTHON
-        // Check is_junction method logic is correct.
         #[cfg(windows)]
         #[pymethod]
         fn is_junction(&self, _vm: &VirtualMachine) -> PyResult<bool> {
-            fs::metadata(&path).map_or(false, |meta| meta.file_type().is_dir())
-                && fs::symlink_metadata(&path).map_or(false, |meta| meta.file_type().is_symlink())
+            Ok(junction::exists(self.pathval.clone()).unwrap_or(false))
         }
 
         #[pymethod(magic)]

Original file line number	Diff line number	Diff line change
`@@ -743,13 +743,10 @@ pub(super) mod _os {`
`743`	`743`	`Ok(false)`
`744`	`744`	`}`
`745`	`745`
`746`		`- // TODO: RUSTPYTHON`
`747`		`- // Check is_junction method logic is correct.`
`748`	`746`	`#[cfg(windows)]`
`749`	`747`	`#[pymethod]`
`750`	`748`	`fn is_junction(&self, _vm: &VirtualMachine) -> PyResult<bool> {`
`751`		`- fs::metadata(&path).map_or(false, \|meta\| meta.file_type().is_dir())`
`752`		`- && fs::symlink_metadata(&path).map_or(false, \|meta\| meta.file_type().is_symlink())`
	`749`	`+ Ok(junction::exists(self.pathval.clone()).unwrap_or(false))`
`753`	`750`	`}`
`754`	`751`
`755`	`752`	`#[pymethod(magic)]`