8000 Un-skip passing typing test · RustPython/RustPython@407f251 · GitHub
[go: up one dir, main page]

Skip to content

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit 407f251

Browse files
committed
Un-skip passing typing test
I missed that the typing test I disabled was on a base test class. Moving the expected failure to the subclass allows the passing test to pass.
1 parent 6cd9e54 commit 407f251

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

Lib/test/test_typing.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -513,8 +513,6 @@ def f():
513513
with self.assertRaises(TypeError):
514514
self.assertNotIsInstance(None, Callable[[], Any])
515515

516-
# TODO: RUSTPYTHON update typing to 3.12
517-
@unittest.expectedFailure
518516
def test_repr(self):
519517
Callable = self.Callable
520518
fullname = f'{Callable.__module__}.Callable'
@@ -707,6 +705,11 @@ def test_paramspec(self): # TODO: RUSTPYTHON, remove when this passes
707705
def test_concatenate(self): # TODO: RUSTPYTHON, remove when this passes
708706
super().test_concatenate() # TODO: RUSTPYTHON, remove when this passes
709707

708+
# TODO: RUSTPYTHON might be fixed by updating typing to 3.12
709+
@unittest.expectedFailure
710+
def test_repr(self): # TODO: RUSTPYTHON, remove when this passes
711+
super().test_repr() # TODO: RUSTPYTHON, remove when this passes
712+
710713

711714
class LiteralTests(BaseTestCase):
712715
def test_basics(self):

0 commit comments

Comments
 (0)
0