Fix not throwing the same error as CPython in test_pathlib.test_expanduser (#5578)

hbina · youknowone · web-flow · commit 2230d6c751eb · 2025-04-05T15:33:33.000+09:00
* Fix not throwing the same error as CPython when trying to expanduser of a non-existent user

Signed-off-by: Hanif Ariffin &lt;hanif.ariffin.4326@gmail.com&gt;

* add pwd test

* Skip pwd test on windows

---------

Signed-off-by: Hanif Ariffin &lt;hanif.ariffin.4326@gmail.com&gt;
Co-authored-by: Jeong YunWon &lt;jeong@youknowone.org&gt;
Co-authored-by: Jeong, YunWon &lt;69878+youknowone@users.noreply.github.com&gt;
diff --git a/extra_tests/snippets/stdlib_pwd.py b/extra_tests/snippets/stdlib_pwd.py
@@ -0,0 +1,12 @@
+import sys
+# windows doesn't support pwd
+if sys.platform.startswith("win"):
+    exit(0)
+
+from testutils import assert_raises
+import pwd
+
+with assert_raises(KeyError):
+    fake_name = 'fake_user'
+    while pwd.getpwnam(fake_name):
+        fake_name += '1'
diff --git a/vm/src/stdlib/pwd.rs b/vm/src/stdlib/pwd.rs
@@ -59,7 +59,7 @@ mod pwd {
         if pw_name.contains('\0') {
             return Err(exceptions::cstring_error(vm));
         }
-        let user = User::from_name(name.as_str()).map_err(|err| err.into_pyexception(vm))?;
+        let user = User::from_name(name.as_str()).ok().flatten();
         let user = user.ok_or_else(|| {
             vm.new_key_error(
                 vm.ctx

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ mod pwd {`
`59`	`59`	`if pw_name.contains('\0') {`
`60`	`60`	`return Err(exceptions::cstring_error(vm));`
`61`	`61`	`}`
`62`		`- let user = User::from_name(name.as_str()).map_err(\|err\| err.into_pyexception(vm))?;`
	`62`	`+ let user = User::from_name(name.as_str()).ok().flatten();`
`63`	`63`	`let user = user.ok_or_else(\|\| {`
`64`	`64`	`vm.new_key_error(`
`65`	`65`	`vm.ctx`