8000 doc: more guess on why PyType failed · RustPython/RustPython@05dbae1 · GitHub
[go: up one dir, main page]

Skip to content

Commit 05dbae1

Browse files
committed
doc: more guess on why PyType failed
1 parent 48e9c57 commit 05dbae1

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

vm/src/builtins/type.rs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,10 @@ pub struct PyType {
5050
#[cfg(feature = "gc")]
5151
impl crate::object::gc::GcTrace for PyType {
5252
fn trace(&self, tracer_fn: &mut crate::object::gc::TracerFn) {
53-
// FIXME(discord9): figure out correct trace() for PyType, simply call each field results in underflow of rc, is PyType all leaked()?
53+
// FIXME(discord9): figure out correct trace() for PyType,
54+
// simply call each field results in underflow of rc, is PyType all leaked()?
55+
// might have to do with similiar problem before which only use PyInner<Erased>(through `.as_object()`) can access header() with correct data
56+
// but PyInner<T> access header() with wrong data, but not sure about that.
5457
self.base.trace(tracer_fn);
5558
self.bases.trace(tracer_fn);
5659
self.mro.trace(tracer_fn);

0 commit comments

Comments
 (0)
0