8000 Allow omitting the trailing comma in macros provided by the `macros` crate. · Issue #1172 · Rust-for-Linux/linux · GitHub
[go: up one dir, main page]

Skip to content
Allow omitting the trailing comma in macros provided by the macros crate. #1172
Open
@BennoLossin

Description

@BennoLossin

Custom syntax in macros should be as similar to normal Rust syntax as possible in order to make them simpler to use. For example, when they use the struct initializer syntax Struct { foo: value, bar: other_value } they should allow both omitting and using a trailing comma. The current module! macro doesn't do this, so implement that.

Also any other macros in the macros crate should be adjusted in separate patches if they don't follow this principle


This requires submitting a proper patch to the LKML and the Rust for Linux mailing list. Please recall to test your changes (including generating the documentation if changed, running the Rust doctests if changed, etc.), to use a proper title for the commit, to sign your commit under the Developer's Certificate of Origin and to add a Suggested-by: tag, and a Link: tag to this issue. Please see https://docs.kernel.org/process/submitting-patches.html and https://rust-for-linux.com/contributing for details.

Metadata

Metadata

Assignees

No one assigned

    Labels

    good first issueGood for newcomersmediumExpected to be an issue of medium difficulty to resolve.• libRelated to the `rust/` library.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      0