Not changing passed oauth_scope when auto-appending .default

tracyboehrer · tracyboehrer · commit 8baad85f5711 · 2020-03-02T11:36:26.000-06:00
diff --git a/libraries/botframework-connector/botframework/connector/auth/microsoft_app_credentials.py b/libraries/botframework-connector/botframework/connector/auth/microsoft_app_credentials.py
@@ -34,9 +34,12 @@ def __init__(
         self.microsoft_app_password = password
         self.app = None
 
-        if self.oauth_scope and not self.oauth_scope.endswith("/.default"):
-            self.oauth_scope += "/.default"
-        self.scopes = [self.oauth_scope]
+        # This check likely needs to be more nuanced than this.  Assuming
+        # "/.default" precludes other valid suffixes
+        scope = self.oauth_scope
+        if oauth_scope and not scope.endswith("/.default"):
+            scope += "/.default"
+        self.scopes = [scope]
 
     @staticmethod
     def empty():
