change const char** to const char* const* in TextSplit

humz2k · humz2k · commit 536e7d01df96 · 2025-02-05T15:01:55.000-05:00
::TextSplit returns a char** now, so you can't cast to a const char** implicitly. By specifying const char* const*, we allow implicit conversions from both char** and const char**. The strings are copied into the vector anyway, so adding the extra const specifier changes nothing.
diff --git a/include/Functions.hpp b/include/Functions.hpp
@@ -393,7 +393,7 @@ TextReplace(const std::string& text, const std::string& replace, const std::stri
  */
 [[maybe_unused]] RLCPPAPI std::vector<std::string> TextSplit(const std::string& text, char delimiter) {
     int count;
-    const char** split = ::TextSplit(text.c_str(), delimiter, &count);
+    const char* const* split = ::TextSplit(text.c_str(), delimiter, &count);
     return std::vector<std::string>(split, split + count);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -393,7 +393,7 @@ TextReplace(const std::string& text, const std::string& replace, const std::stri`
`393`	`393`	`*/`
`394`	`394`	`[[maybe_unused]] RLCPPAPI std::vector<std::string> TextSplit(const std::string& text, char delimiter) {`
`395`	`395`	`int count;`
`396`		`- const char** split = ::TextSplit(text.c_str(), delimiter, &count);`
	`396`	`+ const char* const* split = ::TextSplit(text.c_str(), delimiter, &count);`
`397`	`397`	`return std::vector<std::string>(split, split + count);`
`398`	`398`	`}`
`399`	`399`