Merge pull request supabase#925 from supabase/fix/this-end-is-not-a-function-error

avallete · web-flow · commit b7e23bd01daa · 2025-04-08T17:18:15.000+02:00
fix: this end is not a function error
diff --git a/src/lib/db.ts b/src/lib/db.ts
@@ -198,9 +198,13 @@ ${' '.repeat(5 + lineNumber.toString().length + 2 + lineOffset)}^
           }
           return { data: null, error: { code: error.code, message: error.message } }
         } finally {
-          // If the error isn't a "DatabaseError" assume it's a connection related we kill the connection
-          // To attempt a clean reconnect on next try
-          await this.end()
+          try {
+            // If the error isn't a "DatabaseError" assume it's a connection related we kill the connection
+            // To attempt a clean reconnect on next try
+            await this.end.bind(this)
+          } catch (error) {
+            console.error('Failed to end the connection on error: ', { this: this, end: this.end })
+          }
         }
       }
     },

Original file line number	Diff line number	Diff line change
`@@ -198,9 +198,13 @@ ${' '.repeat(5 + lineNumber.toString().length + 2 + lineOffset)}^`
`198`	`198`	`}`
`199`	`199`	`return { data: null, error: { code: error.code, message: error.message } }`
`200`	`200`	`} finally {`
`201`		`-` `// If the error isn't a "DatabaseError" assume it's a connection related we kill the connection`
`202`		`- // To attempt a clean reconnect on next try`
`203`		`- await this.end()`
	`201`	`+ try {`
	`202`	`+ // If the error isn't a "DatabaseError" assume it's a connection related we kill the connection`
	`203`	`+ // To attempt a clean reconnect on next try`
	`204`	`+ await this.end.bind(this)`
	`205`	`+ } catch (error) {`
	`206`	`+ console.error('Failed to end the connection on error: ', { this: this, end: this.end })`
	`207`	`+ }`
`204`	`208`	`}`
`205`	`209`	`}`
`206`	`210`	`},`