Take UnitTest::Check parameter by const reference

pjohnmeyer · pjohnmeyer · commit 21589e561214 · 2016-07-15T23:23:45.000-05:00
Fixes unittest-cpp#119 and unittest-cpp#7
diff --git a/UnitTest++/Checks.h b/UnitTest++/Checks.h
@@ -9,7 +9,7 @@ namespace UnitTest {
 
 
    template< typename Value >
-   bool Check(Value const value)
+   bool Check(Value const& value)
    {
       return !!value; // doing double negative to avoid silly VS warnings
    }
diff --git a/tests/TestChecks.cpp b/tests/TestChecks.cpp
@@ -315,4 +315,32 @@ namespace {
       CHECK_EQUAL(1234, reporter.lastFailedLine);
    }
 
+   TEST(CheckProperlyDealsWithOperatorBoolOverrides)
+   {
+      class TruthyUnlessCopied
+      {
+      public:
+         TruthyUnlessCopied()
+         : truthy_(true)
+         {
+         }
+
+         TruthyUnlessCopied(const TruthyUnlessCopied& orig)
+         : truthy_(false)
+         {
+         }
+
+         operator bool() const
+         {
+            return truthy_;
+         }
+
+      private:
+         bool truthy_;
+      };
+
+      TruthyUnlessCopied objectThatShouldBeTruthy;
+      CHECK(objectThatShouldBeTruthy);
+   }
+
 }

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,7 @@ namespace UnitTest {`
`9`	`9`
`10`	`10`
`11`	`11`	`template< typename Value >`
`12`		`- bool Check(Value const value)`
	`12`	`+ bool Check(Value const& value)`
`13`	`13`	`{`
`14`	`14`	`return !!value; // doing double negative to avoid silly VS warnings`
`15`	`15`	`}`