8000 Ensure Connector Client is retrieved in teams_info.py (#2062) · Raiffs-bits/botbuilder-python@489d547 · GitHub
[go: up one dir, main page]

Skip to content

Commit 489d547

Browse files
Ensure Connector Client is retrieved in teams_info.py (microsoft#2062)
* Ensure Connector Client is retrieved in teams_info.py * Revert changes in cloud_adapter.py * Ensure Connector Client is retrieved in teams_info.py * Fixed teams member added test with mock ConnectorClient --------- Co-authored-by: tracyboehrer <tracyboehrer@users.noreply.github.com>
1 parent 7a03e65 commit 489d547

File tree

2 files changed

+11
-3
lines changed

2 files changed

+11
-3
lines changed

libraries/botbuilder-core/botbuilder/core/teams/teams_info.py

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
teams_get_meeting_info,
1111
teams_get_channel_data,
1212
)
13-
from botbuilder.core import CloudAdapterBase, BotFrameworkAdapter, TurnContext
13+
from botbuilder.core import CloudAdapterBase, BotFrameworkAdapter, TurnContext, BotAdapter
1414
from botbuilder.schema import Activity, ConversationParameters, ConversationReference
1515
from botbuilder.schema.teams import (
1616
ChannelInfo,
@@ -318,10 +318,15 @@ def get_team_id(turn_context: TurnContext):
318318

319319
@staticmethod
320320
async def _get_connector_client(turn_context: TurnContext) -> ConnectorClient:
321-
return await turn_context.adapter.create_connector_client(
322-
turn_context.activity.service_url
321+
connector_client = turn_context.turn_state.get(
322+
BotAdapter.BOT_CONNECTOR_CLIENT_KEY
323323
)
324324

325+
if connector_client is None:
326+
raise ValueError('This method requires a connector client.')
327+
328+
return connector_client
329+
325330
@staticmethod
326331
async def _get_members(
327332
connector_client: ConnectorClient, conversation_id: str

libraries/botbuilder-core/tests/teams/test_teams_activity_handler.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -592,6 +592,9 @@ async def test_on_teams_members_added_activity(self):
592592

593593
turn_context = TurnContext(SimpleAdapter(), activity)
594594

595+
mock_connector_client = await SimpleAdapter.create_connector_client(self, turn_context.activity.service_url)
596+
turn_context.turn_state[BotAdapter.BOT_CONNECTOR_CLIENT_KEY] = mock_connector_client
597+
595598
# Act
596599
bot = TestingTeamsActivityHandler()
597600
await bot.on_turn(turn_context)

0 commit comments

Comments
 (0)
0