MAINT Clean deprecated pdp_lim as constructor param of PartialDependenceDisplay (scikit-learn#26426)

jeremiedbb · REDVM · commit 3e6d53194a5a · 2023-11-16T16:26:10.000+01:00
diff --git a/sklearn/inspection/_plot/partial_dependence.py b/sklearn/inspection/_plot/partial_dependence.py
@@ -1,5 +1,4 @@
 import numbers
-import warnings
 from itertools import chain
 from math import ceil
 
@@ -63,18 +62,6 @@ class PartialDependenceDisplay:
     deciles : dict
         Deciles for feature indices in ``features``.
 
-    pdp_lim : dict or None
-        Global min and max average predictions, such that all plots will have
-        the same scale and y limits. `pdp_lim[1]` is the global min and max for
-        single partial dependence curves. `pdp_lim[2]` is the global min and
-        max for two-way partial dependence curves. If `None`, the limit will be
-        inferred from the global minimum and maximum of all predictions.
-
-        .. deprecated:: 1.1
-           Pass the parameter `pdp_lim` to
-           :meth:`~sklearn.inspection.PartialDependenceDisplay.plot` instead.
-           It will be removed in 1.3.
-
     kind : {'average', 'individual', 'both'} or list of such str, \
             default='average'
         Whether to plot the partial dependence averaged across all the samples
@@ -236,7 +223,6 @@ def __init__(
         feature_names,
         target_idx,
         deciles,
-        pdp_lim="deprecated",
         kind="average",
         subsample=1000,
         random_state=None,
@@ -246,7 +232,6 @@ def __init__(
         self.features = features
         self.feature_names = feature_names
         self.target_idx = target_idx
-        self.pdp_lim = pdp_lim
         self.deciles = deciles
         self.kind = kind
         self.subsample = subsample
@@ -1233,27 +1218,6 @@ def plot(
                 f" of such values. Currently, kind={self.kind!r}"
             )
 
-        # FIXME: remove in 1.3
-        if self.pdp_lim != "deprecated":
-            warnings.warn(
-                (
-                    "The `pdp_lim` parameter is deprecated in version 1.1 and will be "
-                    "removed in version 1.3. Provide `pdp_lim` to the `plot` method."
-                    "instead."
-                ),
-                FutureWarning,
-            )
-            if pdp_lim is not None and self.pdp_lim != pdp_lim:
-                warnings.warn(
-                    (
-                        "`pdp_lim` has been passed in both the constructor and the"
-                        " `plot` method. For backward compatibility, the parameter from"
-                        " the constructor will be used."
-                    ),
-                    UserWarning,
-                )
-            pdp_lim = self.pdp_lim
-
         # Center results before plotting
         if not centered:
             pd_results_ = self.pd_results
diff --git a/sklearn/inspection/_plot/tests/test_plot_partial_dependence.py b/sklearn/inspection/_plot/tests/test_plot_partial_dependence.py
@@ -3,7 +3,6 @@
 
 import pytest
 from numpy.testing import assert_allclose
-import warnings
 
 from sklearn.datasets import load_diabetes
 from sklearn.datasets import load_iris
@@ -857,35 +856,6 @@ def test_grid_resolution_with_categorical(pyplot, categorical_features, array_ty
         )
 
 
-# TODO(1.3): remove
-def test_partial_dependence_display_deprecation(pyplot, clf_diabetes, diabetes):
-    """Check that we raise the proper warning in the display."""
-    disp = PartialDependenceDisplay.from_estimator(
-        clf_diabetes,
-        diabetes.data,
-        [0, 2],
-        grid_resolution=25,
-        feature_names=diabetes.feature_names,
-    )
-
-    deprecation_msg = "The `pdp_lim` parameter is deprecated"
-    overwritting_msg = (
-        "`pdp_lim` has been passed in both the constructor and the `plot` method"
-    )
-
-    disp.pdp_lim = None
-    # case when constructor and method parameters are the same
-    with pytest.warns(FutureWarning, match=deprecation_msg):
-        disp.plot(pdp_lim=None)
-    # case when constructor and method parameters are different
-    with warnings.catch_warnings(record=True) as record:
-        warnings.simplefilter("always", FutureWarning)
-        disp.plot(pdp_lim=(0, 1))
-    assert len(record) == 2
-    for warning in record:
-        assert warning.message.args[0].startswith((deprecation_msg, overwritting_msg))
-
-
 @pytest.mark.parametrize("kind", ["individual", "average", "both"])
 @pytest.mark.parametrize("centered", [True, False])
 def test_partial_dependence_plot_limits_one_way(
