Implements Implicit Conversion

AlexCatarino · AlexCatarino · commit 78b644be821f · 2017-12-28T13:48:14.000Z
diff --git a/src/runtime/converter.cs b/src/runtime/converter.cs
@@ -513,6 +513,20 @@ internal static bool ToManagedValue(IntPtr value, Type obType,
                 return ToManagedValue(value, underlyingType, out result, setError);
             }
 
+            var opImplicit = obType.GetMethod("op_Implicit", new[] { obType });
+            if (opImplicit != null)
+            {
+                if (ToManagedValue(value, opImplicit.ReturnType, out result, setError))
+                {
+                    opImplicit = obType.GetMethod("op_Implicit", new[] { result.GetType() });
+                    if (opImplicit != null)
+                    {
+                        result = opImplicit.Invoke(null, new[] { result });
+                    }
+                    return opImplicit != null;
+                }
+            }
+
             return ToPrimitive(value, obType, out result, setError);
         }
 
diff --git a/src/runtime/methodbinder.cs b/src/runtime/methodbinder.cs
@@ -408,6 +408,13 @@ internal Binding Bind(IntPtr inst, IntPtr args, IntPtr kw, MethodBase info, Meth
                                             typematch = true;
                                             clrtype = pi[n].ParameterType;
                                         }
+                                        // this takes care of implicit conversions
+                                        var opImplicit = pi[n].ParameterType.GetMethod("op_Implicit", new[] { clrtype });
+                                        if (opImplicit != null)
+                                        {
+                                            typematch = opImplicit.ReturnType == pi[n].ParameterType;
+                                            clrtype = pi[n].ParameterType;
+                                        }
                                     }
                                     Runtime.XDecref(pyoptype);
                                     if (!typematch)

Original file line number	Diff line number	Diff line change
`@@ -408,6 +408,13 @@ internal Binding Bind(IntPtr inst, IntPtr args, IntPtr kw, MethodBase info, Meth`
`408`	`408`	`typematch = true;`
`409`	`409`	`clrtype = pi[n].ParameterType;`
`410`	`410`	`}`
	`411`	`+ // this takes care of implicit conversions`
	`412`	`+ var opImplicit = pi[n].ParameterType.GetMethod("op_Implicit", new[] { clrtype });`
	`413`	`+ if (opImplicit != null)`
	`414`	`+ {`
	`415`	`+ typematch = opImplicit.ReturnType == pi[n].ParameterType;`
	`416`	`+ clrtype = pi[n].ParameterType;`
	`417`	`+ }`
`411`	`418`	`}`
`412`	`419`	`Runtime.XDecref(pyoptype);`
`413`	`420`	`if (!typematch)`