Revert "Enable C# parameters of type object accept any argument, passed from Python (pythonnet#853)" (pythonnet#882)

filmor · AlexCatarino · commit 3dfab861a0ad · 2020-06-18T00:52:04.000+01:00
This reverts commit 43c972d.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -41,7 +41,6 @@ This document follows the conventions laid out in [Keep a CHANGELOG][].
 -   Reattach python exception traceback information (#545)
 -   PythonEngine.Intialize will now call `Py_InitializeEx` with a default value of 0, so signals will not be configured by default on embedding. This is different from the previous behaviour, where `Py_Initialize` was called instead, which sets initSigs to 1. ([#449][i449])
 -   Refactored MethodBinder.Bind in preparation to make it extensible (#829)
--   When calling C# from Python, enable passing argument of any type to a parameter of C# type `object` by wrapping it into `PyObject` instance. ([#881][i881])
 -   Look for installed Windows 10 sdk's during installation instead of relying on specific versions.
 -   improved performance of calls from Python to C#
 
diff --git a/src/embed_tests/Python.EmbeddingTest.csproj b/src/embed_tests/Python.EmbeddingTest.csproj
@@ -89,7 +89,6 @@
     <Compile Include="TestDomainReload.cs" />
     <Compile Include="TestExample.cs" />
     <Compile Include="TestFinalizer.cs" />
-    <Compile Include="TestInstanceWrapping.cs" />
     <Compile Include="TestPyAnsiString.cs" />
     <Compile Include="TestPyFloat.cs" />
     <Compile Include="TestPyInt.cs" />
diff --git a/src/embed_tests/TestInstanceWrapping.cs b/src/embed_tests/TestInstanceWrapping.cs
diff --git a/src/runtime/converter.cs b/src/runtime/converter.cs
@@ -471,9 +471,12 @@ internal static bool ToManagedValue(IntPtr value, Type obType,
                     return ToArray(value, typeof(object[]), out result, setError);
                 }
 
-                Runtime.XIncref(value); // PyObject() assumes ownership
-                result = new PyObject(value);
-                return true;
+                if (setError)
+                {
+                    Exceptions.SetError(Exceptions.TypeError, "value cannot be converted to Object");
+                }
+
+                return false;
             }
 
             // Conversion to 'Type' is done using the same mappings as above for objects.

Original file line number	Diff line number	Diff line change
`@@ -471,9 +471,12 @@ internal static bool ToManagedValue(IntPtr value, Type obType,`
`471`	`471`	`return ToArray(value, typeof(object[]), out result, setError);`
`472`	`472`	`}`
`473`	`473`
`474`		`- Runtime.XIncref(value); // PyObject() assumes ownership`
`475`		`- result = new PyObject(value);`
`476`		`- return true;`
	`474`	`+ if (setError)`
	`475`	`+ {`
	`476`	`+ Exceptions.SetError(Exceptions.TypeError, "value cannot be converted to Object");`
	`477`	`+ }`
	`478`	`+`
	`479`	`+ return false;`
`477`	`480`	`}`
`478`	`481`
`479`	`482`	`// Conversion to 'Type' is done using the same mappings as above for objects.`