Backport PR matplotlib#16112 on branch v2.2.x (CI: Fail when failed to install dependencies) (matplotlib#16137)

Kojoley · NelleV · tacaswell · tacaswell · commit 5e13fa9017d5 · 2020-01-20T12:18:15.000-05:00
* Merge pull request matplotlib#16112 from Kojoley/ci-travis-fail-when-dep-install-fails CI: Fail when failed to install dependencies * CI: backport osx on travis changes en-mass This will move testing on travis to python3 (from python2), however I am not sure it is worth the effort of moving brew on travis back to python2 so that we can in very short order delete this branch and close out the 2.2.x series (now that python2 is EOL). * CI: accept that brew will be verbose * CI: bump sphinx version to pick up support for newer docutils * CI: remove mac builds on travis The brew configuration has bit-rotted * CI: remove the nightly build from travis * CI: add py38 to build matrix * Revert "CI: remove mac builds on travis" This reverts commit 4da7fa1. * CI: try removing the osx_image specification Co-authored-by: Nelle Varoquaux <nelle.varoquaux@gmail.com> Co-authored-by: Thomas A Caswell <tcaswell@gmail.com>
diff --git a/.travis.yml b/.travis.yml
@@ -87,7 +87,7 @@ matrix:
         - PYTEST_COV=pytest-cov==2.3.1
         - PYTEST_RERUNFAILURES='pytest-rerunfailures<6'  # 6 needs pytest >=3.8
         - PYTEST_TIMEOUT=pytest-timeout==1.2.1  # Newer pytest-timeouts don't support pytest <3.4.
-        - SPHINX=sphinx==1.3
+        - SPHINX=sphinx==1.3.3
     - python: 3.4
       env:
         - PYTHON_ARGS=-OO
@@ -96,10 +96,8 @@ matrix:
       env: DELETE_FONT_CACHE=1 PANDAS='pandas<0.21.0' PYTEST_PEP8=pytest-pep8 RUN_PEP8=--pep8
     - python: 3.7
       sudo: true
-    - python: "nightly"
-      env: PRE=--pre
+    - python: 3.8
     - os: osx
-      osx_image: xcode7.3
       language: generic  # https://github.com/travis-ci/travis-ci/issues/2312
       env:
         - MOCK=mock
@@ -114,8 +112,7 @@ matrix:
           # `cache` does not support `env`-like `global` so copy-paste from top
           - $HOME/.ccache  # https://github.com/travis-ci/travis-ci/issues/5853
           - $HOME/.cache/matplotlib
-  allow_failures:
-    - python: "nightly"
+
 
 before_install:
   - |
@@ -125,13 +122,20 @@ before_install:
       export PATH=$PATH:/tmp/λ
       export PATH=/usr/lib/ccache:$PATH
     else
+      set -e
       brew update
-      brew tap homebrew/gui
-      # brew install python libpng ffmpeg imagemagick mplayer ccache
+      brew uninstall numpy gdal postgis
+      brew unlink python@2
+      brew upgrade python
+      brew install ffmpeg imagemagick mplayer ccache
+      hash -r
+      which python
+      python --version
+      set +e
       # We could install ghostscript and inkscape here to test svg and pdf
       # but this makes the test time really long.
       # brew install ghostscript inkscape
-      export PATH=/usr/local/opt/ccache/libexec:$PATH
+      export PATH=/usr/local/opt/python/libexec/bin:/usr/local/opt/ccache/libexec:$PATH
     fi
 
 install:
@@ -159,6 +163,8 @@ install:
         $PYPARSING \
         $DATEUTIL \
         $SPHINX
+  - |
+    # Install optional dependencies from PyPI.
     # GUI toolkits are pip-installable only for some versions of Python so
     # don't fail if we can't install them.  Make it easier to check whether the
     # install was successful by trying to import the toolkit (sometimes, the
