8000 Bugfix with undefined children_hooks when package is None by azjps · Pull Request #565 · PythonCharmers/python-future · GitHub
[go: up one dir, main page]
Skip to content

Bugfix with undefined children_hooks when package is None #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2024
Merged

Bugfix with undefined children_hooks when package is None #565

merged 1 commit into from
Feb 21, 2024

Conversation

azjps
Copy link
@azjps azjps commented Jun 16, 2020 •
edited
Loading

Fix the code path in touch_import_top() where package is None (e.g. import six instead of from six import string_types). Fixed a minor bug in this code path, so that a custom fixer can use it.
(touch_import_top() is always called with a package within the futurize codebase.)

@azjps
Bugfix with undefined children_hooks when package is None
fa73942 
touch_import_top() is always called with a package within
the futurize codebase, but it does have a code path where
package can be None (e.g. import six instead of from six
import string_types). Fixed a minor bug in this code path,
so that a custom fixer can use it.

Change-Id: Iec2891586fe852e35a91c69d2fb146645d7c53dd
@edschofield edschofield merged commit 679e2fe into PythonCharmers:master Feb 21, 2024
@edschofield
Copy link
Contributor

Thanks @azjps !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azjps @edschofield
0