Added ssl_key_password param #1145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed tests and linter issues caused by adding SSL key password parameter.
|
I couldn't manage to handle Django tests because I can't understand what exactly goes wrong, it would be nice if someone pointed me in the right direction of thought. |
|
Don't care about Django tests. It is expected failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1145 +/- ##
==========================================
+ Coverage 86.27% 86.28% +0.01%
==========================================
Files 17 17
Lines 2434 2436 +2
Branches 257 258 +1
==========================================
+ Hits 2100 2102 +2
Misses 249 249
Partials 85 85 ☔ View full report in Codecov by Sentry. |
|
@methane Thanks a lot for your help and for all your efforts you put into the project! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for SSL private key password in Connection class to handle encrypted keys.