Avoid segfault when there is a poll error

Cito · Cito · commit 7d93eb222a48 · 2023-09-06T17:47:18.000+02:00
diff --git a/ext/pgconn.c b/ext/pgconn.c
@@ -45,7 +45,7 @@ conn_getattr(connObject *self, PyObject *nameobj)
     /* postmaster host */
     if (!strcmp(name, "host")) {
         char *r = PQhost(self->cnx);
-        if (!r || r[0] == '/') /* Pg >= 9.6 can return a Unix socket path */
+        if (!r || r[0] == '/') /* this can return a Unix socket path */
             r = "localhost";
         return PyUnicode_FromString(r);
     }
@@ -1577,7 +1577,6 @@ conn_poll(connObject *self, PyObject *noargs)
 
     if (rc == PGRES_POLLING_FAILED) {
         set_error(InternalError, "Polling failed", self->cnx, NULL);
-        Py_XDECREF(self);
         return NULL;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ conn_getattr(connObject self, PyObject nameobj)`
`45`	`45`	`/* postmaster host */`
`46`	`46`	`if (!strcmp(name, "host")) {`
`47`	`47`	`char *r = PQhost(self->cnx);`
`48`		`- if (!r \|\| r[0] == '/') /* Pg >= 9.6 can return a Unix socket path */`
	`48`	`+ if (!r \|\| r[0] == '/') /* this can return a Unix socket path */`
`49`	`49`	`r = "localhost";`
`50`	`50`	`return PyUnicode_FromString(r);`
`51`	`51`	`}`
`@@ -1577,7 +1577,6 @@ conn_poll(connObject self, PyObject noargs)`
`1577`	`1577`
`1578`	`1578`	`if (rc == PGRES_POLLING_FAILED) {`
`1579`	`1579`	`set_error(InternalError, "Polling failed", self->cnx, NULL);`
`1580`		`- Py_XDECREF(self);`
`1581`	`1580`	`return NULL;`
`1582`	`1581`	`}`
`1583`	`1582`