Add ARIA labels to select elements in the version switcher

Privat33r-dev · web-flow · commit 6b0b2b78f687 · 2024-10-28T10:28:08.000+01:00
Fix in CPython didn't apply here. python/cpython#125934
diff --git a/templates/switchers.js b/templates/switchers.js
@@ -26,7 +26,7 @@
   }
 
   function build_version_select(release) {
-    let buf = ['<select id="version_select">'];
+    let buf = ['<select id="version_select" aria-label="Python version">'];
     const major_minor = release.split(".").slice(0, 2).join(".");
 
     Object.entries(all_versions).forEach(function([version, title]) {
@@ -42,7 +42,7 @@
   }
 
   function build_language_select(current_language) {
-    let buf = ['<select id="language_select">'];
+    let buf = ['<select id="language_select" aria-label="Language">'];
 
     Object.entries(all_languages).forEach(function([language, title]) {
       if (language === current_language) {

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@`
`26`	`26`	`}`
`27`	`27`
`28`	`28`	`function build_version_select(release) {`
`29`		`- let buf = ['<select id="version_select">'];`
	`29`	`+ let buf = ['<select id="version_select" aria-label="Python version">'];`
`30`	`30`	`const major_minor = release.split(".").slice(0, 2).join(".");`
`31`	`31`
`32`	`32`	`Object.entries(all_versions).forEach(function([version, title]) {`
`@@ -42,7 +42,7 @@`
`42`	`42`	`}`
`43`	`43`
`44`	`44`	`function build_language_select(current_language) {`
`45`		`- let buf = ['<select id="language_select">'];`
	`45`	`+ let buf = ['<select id="language_select" aria-label="Language">'];`
`46`	`46`
`47`	`47`	`Object.entries(all_languages).forEach(function([language, title]) {`
`48`	`48`	`if (language === current_language) {`