8000 Fix exception params · Powercoder64/ffmpeg-python@9a487e8 · GitHub
[go: up one dir, main page]

Skip to content

Commit 9a487e8

Browse files
committed
Fix exception params
1 parent 940b05f commit 9a487e8

File tree

3 files changed

+21
-21
lines changed

3 files changed

+21
-21
lines changed

ffmpeg/_probe.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ def probe(filename):
1616
p = subprocess.Popen(args, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
1717
out, err = p.communicate()
1818
if p.returncode != 0:
19-
raise Error(err)
19+
raise Error('ffprobe', out, err)
2020
return json.loads(out.decode('utf-8'))
2121

2222

ffmpeg/_run.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,8 @@
2424

2525

2626
class Error(Exception):
27-
def __init__(self, stream_spec, stdout, stderr):
28-
super(Error, self).__init__('ffmpeg error (see stderr output for detail)')
29-
self.stream_spec = stream_spec
27+
def __init__(self, cmd, stdout, stderr):
28+
super(Error, self).__init__('{} error (see stderr output for detail)'.format(cmd))
3029
self.stdout = stdout
3130
self.stderr = stderr
3231

@@ -197,7 +196,7 @@ def run(
197196
out, err = p.communicate(input)
198197
retcode = p.poll()
199198
if retcode:
200-
raise Error(stream_spec, out, err)
199+
raise Error('ffmpeg', out, err)
201200
return out, err
202201

203202

ffmpeg/tests/test_ffmpeg.py

Lines changed: 17 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ def test_stream_repr():
101101
assert repr(dummy_out) == 'dummy()[{!r}] <{}>'.format(dummy_out.label, dummy_out.node.short_hash)
102102

103103

104-
def test_get_args_simple():
104+
def test__get_args__simple():
105105
out_file = ffmpeg.input('dummy.mp4').output('dummy2.mp4')
106106
assert out_file.get_args() == ['-i', 'dummy.mp4', 'dummy2.mp4']
107107

@@ -138,7 +138,7 @@ def _get_complex_filter_example():
138138
)
139139

140140

141-
def test_get_args_complex_filter():
141+
def test__get_args__complex_filter():
142142
out = _get_complex_filter_example()
143143
args = ffmpeg.get_args(out)
144144
assert args == ['-i', TEST_INPUT_FILE1,
@@ -309,13 +309,13 @@ def _get_drawtext_text_repr(text):
309309
# subprocess.check_call(['ffmpeg', '-version'])
310310

311311

312-
def test_compile():
312+
def test__compile():
313313
out_file = ffmpeg.input('dummy.mp4').output('dummy2.mp4')
314314
assert out_file.compile() == ['ffmpeg', '-i', 'dummy.mp4', 'dummy2.mp4']
315315
assert out_file.compile(cmd='ffmpeg.old') == ['ffmpeg.old', '-i', 'dummy.mp4', 'dummy2.mp4']
316316

317317

318-
def test_run():
318+
def test__run():
319319
stream = _get_complex_filter_example()
320320
out, err = ffmpeg.run(stream)
321321
assert out is None
@@ -324,7 +324,7 @@ def test_run():
324324

325325
@pytest.mark.parametrize('capture_stdout', [True, False])
326326
@pytest.mark.parametrize('capture_stderr', [True, False])
327-
def test_run__capture_out(mocker, capture_stdout, capture_stderr):
327+
def test__run__capture_out(mocker, capture_stdout, capture_stderr):
328328
mocker.patch.object(ffmpeg._run, 'compile', return_value=['echo', 'test'])
329329
stream = _get_simple_example()
330330
out, err = ffmpeg.run(stream, capture_stdout=capture_stdout, capture_stderr=capture_stderr)
@@ -338,7 +338,7 @@ def test_run__capture_out(mocker, capture_stdout, capture_stderr):
338338
assert err is None
339339

340340

341-
def test_run__input_output(mocker):
341+
def test__run__input_output(mocker):
342342
mocker.patch.object(ffmpeg._run, 'compile', return_value=['cat'])
343343
stream = _get_simple_example()
344344
out, err = ffmpeg.run(stream, input='test', capture_stdout=True)
@@ -348,11 +348,12 @@ def test_run__input_output(mocker):
348348

349349
@pytest.mark.parametrize('capture_stdout', [True, False])
350350
@pytest.mark.parametrize('capture_stderr', [True, False])
351-
def test_run__error(mocker, capture_stdout, capture_stderr):
351+
def test__run__error(mocker, capture_stdout, capture_stderr):
352352
mocker.patch.object(ffmpeg._run, 'compile', return_value=['ffmpeg'])
353353
stream = _get_complex_filter_example()
354354
with pytest.raises(ffmpeg.Error) as excinfo:
355355
out, err = ffmpeg.run(stream, capture_stdout=capture_stdout, capture_stderr=capture_stderr)
356+
assert str(excinfo.value) == 'ffmpeg error (see stderr output for detail)'
356357
out = excinfo.value.stdout
357358
err = excinfo.value.stderr
358359
if capture_stdout:
@@ -365,24 +366,24 @@ def test_run__error(mocker, capture_stdout, capture_stderr):
365366
assert err is None
366367

367368

368-
def test_run__multi_output():
369+
def test__run__multi_output():
369370
in_ = ffmpeg.input(TEST_INPUT_FILE1)
370371
out1 = in_.output(TEST_OUTPUT_FILE1)
371372
out2 = in_.output(TEST_OUTPUT_FILE2)
372373
ffmpeg.run([out1, out2], overwrite_output=True)
373374

374375

375-
def test_run__dummy_cmd():
376+
def test__run__dummy_cmd():
376377
stream = _get_complex_filter_example()
377378
ffmpeg.run(stream, cmd='true')
378379

379380

380-
def test_run__dummy_cmd_list():
381+
def test__run__dummy_cmd_list():
381382
stream = _get_complex_filter_example()
382383
ffmpeg.run(stream, cmd=['true', 'ignored'])
383384

384385

385-
def test_filter__custom():
386+
def test__filter__custom():
386387
stream = ffmpeg.input('dummy.mp4')
387388
stream = ffmpeg.filter_(stream, 'custom_filter', 'a', 'b', kwarg1='c')
388389
stream = ffmpeg.output(stream, 'dummy2.mp4')
@@ -394,7 +395,7 @@ def test_filter__custom():
394395
]
395396

396397

397-
def test_filter__custom_fluent():
398+
def test__filter__custom_fluent():
398399
stream = (ffmpeg
399400
.input('dummy.mp4')
400401
.filter_('custom_filter', 'a', 'b', kwarg1='c')
@@ -408,7 +409,7 @@ def test_filter__custom_fluent():
408409
]
409410

410411

411-
def test_merge_outputs():
412+
def test__merge_outputs():
412413
in_ = ffmpeg.input('in.mp4')
413414
out1 = in_.output('out1.mp4')
414415
out2 = in_.output('out2.mp4')
@@ -484,14 +485,14 @@ def test_pipe():
484485
assert out_data == in_data[start_frame*frame_size:]
485486

486487

487-
def test_ffprobe():
488+
def test__probe():
488489
data = ffmpeg.probe(TEST_INPUT_FILE1)
489490
assert set(data.keys()) == {'format', 'streams'}
490491
assert data['format']['duration'] == '7.036000'
491492

492493

493-
def test_ffprobe_exception():
494+
def test__probe__exception():
494495
with pytest.raises(ffmpeg.Error) as excinfo:
495496
ffmpeg.probe(BOGUS_INPUT_FILE)
496-
assert str(excinfo.value) == 'ffprobe error'
497+
assert str(excinfo.value) == 'ffprobe error (see stderr output for detail)'
497498
assert 'No such file or directory'.encode() in excinfo.value.stderr

0 commit comments

Comments
 (0)
0