8000 Replaced WorkspaceFileSystemWrapper with Get-Content and Get-ChildItem by dkattan · Pull Request #2136 · PowerShell/PowerShellEditorServices · GitHub
[go: up one dir, main page]
Skip to content

Replaced WorkspaceFileSystemWrapper with Get-Content and Get-ChildItem#2136

Draft
dkattan wants to merge 6 commits intoPowerShell:mainfrom
dkattan:feature/get-content
Draft

Replaced WorkspaceFileSystemWrapper with Get-Content and Get-ChildItem#2136
dkattan wants to merge 6 commits intoPowerShell:mainfrom
dkattan:feature/get-content

Conversation

@dkattan
Copy link
Contributor
@dkattan dkattan commented Feb 13, 2024 •
edited
Loading

PR Summary

Removes artificial Uri schema restriction, provides a mechanism for language clients to specify URIs that direct to PSProviders

PR Context

@dkattan dkattan force-pushed the feature/get-content branch from 59af6f2 to 42c028f Compare February 14, 2024 17:01
@dkattan dkattan marked this pull request as ready for review February 14, 2024 19:55
@dkattan dkattan requested a review from a team February 14, 2024 19:55
@dkattan
Copy link
Contributor Author
dkattan commented Feb 14, 2024

@andyleejordan Curious your thoughts on this. It ended up being heavier-handed than I wanted with all the async changes, but I'm wondering if that would be desirable if I split it into a separate MR? I know @SeeminglyScience doesn't want me changing the public interfaces, but they likely should've been Task<> from the start, async or not.

@dkattan dkattan force-pushed the feature/get-content branch from 42c028f to e72a219 Compare February 15, 2024 17:41
@dkattan dkattan changed the title Asyncify WorkspaceService/Perform File IO operations through PowerShell Replaced WorkspaceFileSystemWrapper with Get-Content and Get-ChildItem Feb 15, 2024
@dkattan dkattan force-pushed the feature/get-content branch from 974e92e to 1faf9f2 Compare February 15, 2024 21:35
@dkattan dkattan changed the title Replaced WorkspaceFileSystemWrapper with Get-Content and Get-ChildItem Draft: Replaced WorkspaceFileSystemWrapper with Get-Content and Get-ChildItem Feb 15, 2024
@dkattan dkattan marked this pull request as draft February 15, 2024 21:36
@dkattan dkattan changed the title Draft: Replaced WorkspaceFileSystemWrapper with Get-Content and Get-ChildItem Replaced WorkspaceFileSystemWrapper with Get-Content and Get-ChildItem Feb 15, 2024
@SeeminglyScience
Copy link
Collaborator
SeeminglyScience commented Feb 15, 2024

I know @SeeminglyScience doesn't want me changing the public interfaces, but they likely should've been Task<> from the start, async or not.

Can you talk through what you're trying to solve? When you make a synchronous method return Task<> all you're really doing is requiring wrapper object be created that will be immediately discarded. It doesn't change the behavior at all if that's the assumption.

@dkattan dkattan force-pushed the feature/get-content branch from 1faf9f2 to 974e92e Compare February 16, 2024 18:36
@andyleejordan andyleejordan force-pushed the main branch 2 times, most recently from caa9e27 to 677f42c Compare May 3, 2024 23:07
@andyleejordan andyleejordan force-pushed the main branch 2 times, most recently from 80b2351 to 9ce8911 Compare November 18, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dkattan @SeeminglyScience
0