Run PowerShell class static methods in the correct Runspace/SessionState #4209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulHigin
suggested changes
Jul 10, 2017
src/System.Management.Automation/engine/runtime/Operations/ClassOps.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/runtime/Operations/ClassOps.cs
Outdated
Show resolved
Hide resolved
src/System.Management.Automation/engine/runtime/Operations/ClassOps.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4001
Summary
When the same script file gets executed in multiple Runspaces, the RuntimeType generated from the powershell class defined in the file will be shared among those Runspaces. For different Runspaces, different SessionState should be used to run the static methods.
Fix
We use the
SessionStateKeeperto query for the correctSessionStateto use for a static method call.We already use
SessionStateKeeperto track theRunspace/SessionStatewhere a PowerShell class is defined, and thus we can leverage this for the static method invocation.